Skip to content

refactor: ensure lodash is default-imported#6716

Merged
Josh-Cena merged 1 commit into
mainfrom
jc/default-lodash
Feb 19, 2022
Merged

refactor: ensure lodash is default-imported#6716
Josh-Cena merged 1 commit into
mainfrom
jc/default-lodash

Conversation

@Josh-Cena

Copy link
Copy Markdown
Collaborator

Motivation

Continuation of #6661; lodash can only be default-imported once we are ESM. Also removed a few lodash usages.

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Feb 19, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 19, 2022
@netlify

netlify Bot commented Feb 19, 2022

Copy link
Copy Markdown

✔️ [V2]

🔨 Explore the source changes: 53fa129

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6210c0699c892a0009593b8a

😎 Browse the preview: https://deploy-preview-6716--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 57
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6716--docusaurus-2.netlify.app/

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 781 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 48 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 590 kB
website/build/index.html 37.6 kB

compressed-size-action

@Josh-Cena
Josh-Cena merged commit ea6ceaa into main Feb 19, 2022
@Josh-Cena
Josh-Cena deleted the jc/default-lodash branch February 19, 2022 10:15
@Josh-Cena Josh-Cena mentioned this pull request Feb 19, 2022
1 task
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants