Skip to content

refactor(plugin-pwa): migrate package to TS#5941

Merged
slorber merged 3 commits into
facebook:mainfrom
armano2:refactor/pwa
Nov 16, 2021
Merged

refactor(plugin-pwa): migrate package to TS#5941
slorber merged 3 commits into
facebook:mainfrom
armano2:refactor/pwa

Conversation

@armano2

@armano2 armano2 commented Nov 13, 2021

Copy link
Copy Markdown
Contributor

Motivation

#5817

Have you read the Contributing Guidelines on pull requests?

yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2021
@netlify

netlify Bot commented Nov 13, 2021

Copy link
Copy Markdown

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: ff4ce59

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6190a519f5a83800077cec1d

😎 Browse the preview: https://deploy-preview-5941--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Nov 13, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5941--docusaurus-2.netlify.app/

@Josh-Cena Josh-Cena added status: blocked This issue is blocked by another issue or external dep and can't be pushed further. pr: maintenance This PR does not produce any behavior differences to end users when upgrading. labels Nov 14, 2021
@slorber

slorber commented Nov 16, 2021

Copy link
Copy Markdown
Collaborator

awesome 👍 thanks again

@slorber slorber merged commit 85fcd9e into facebook:main Nov 16, 2021
@armano2 armano2 deleted the refactor/pwa branch November 16, 2021 19:42
@Josh-Cena Josh-Cena removed the status: blocked This issue is blocked by another issue or external dep and can't be pushed further. label Nov 17, 2021
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants