Skip to content

docs(v2): add a missing "export" from the initial template#4546

Merged
slorber merged 2 commits into
facebook:masterfrom
Foxeye-Rinx:docs(v2)-add-missing-export-from-initial-template-instruction
Apr 2, 2021
Merged

docs(v2): add a missing "export" from the initial template#4546
slorber merged 2 commits into
facebook:masterfrom
Foxeye-Rinx:docs(v2)-add-missing-export-from-initial-template-instruction

Conversation

@Foxeye-Rinx

@Foxeye-Rinx Foxeye-Rinx commented Apr 1, 2021

Copy link
Copy Markdown
Contributor

Motivation

Improve the initial template
For now, if a new user creates the project using the CLI, it opens at http://localhost:3000.
It is convenience for the user to continue reading at the guide that already shows on http://localhost:3000.
But it's missing an" export" command on the guide and it makes the guide doesn't work.
This commit is consistent with the official guide at https://docusaurus.io/docs/creating-pages (current version: 2.0.0-alpha.72)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No

Related PRs

#4320

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 1, 2021
@github-actions

github-actions Bot commented Apr 1, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 67
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4546--docusaurus-2.netlify.app/

@slorber

slorber commented Apr 2, 2021

Copy link
Copy Markdown
Collaborator

Thanks, I'm going to expert the fn directly :)

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 2, 2021
@netlify

netlify Bot commented Apr 2, 2021

Copy link
Copy Markdown

[V1]

Built with commit a2613fb

https://deploy-preview-4546--docusaurus-1.netlify.app

@netlify

netlify Bot commented Apr 2, 2021

Copy link
Copy Markdown

[V2]

Built with commit a2613fb

https://deploy-preview-4546--docusaurus-2.netlify.app

@slorber
slorber merged commit 9fceeb9 into facebook:master Apr 2, 2021
@Foxeye-Rinx
Foxeye-Rinx deleted the docs(v2)-add-missing-export-from-initial-template-instruction branch April 2, 2021 12:40
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
…4546)

* docs(v2): add a missing "export" from the initial template

* Update create-a-page.md

Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants