Skip to content

feat(v2): add Vietnamese translation for classic theme#4422

Merged
lex111 merged 2 commits into
facebook:masterfrom
quantrung9:vi-translation
Mar 15, 2021
Merged

feat(v2): add Vietnamese translation for classic theme#4422
lex111 merged 2 commits into
facebook:masterfrom
quantrung9:vi-translation

Conversation

@quantrung9

Copy link
Copy Markdown
Contributor

Motivation

I added the Vietnamese translation. Feel free to correct any mistakes.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @quanengineering!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify

netlify Bot commented Mar 13, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit fcd2170

https://deploy-preview-4422--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Mar 13, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4422--docusaurus-2.netlify.app/classic/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 13, 2021
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Comment thread packages/docusaurus-theme-classic/codeTranslations/vi.json Outdated
@netlify

netlify Bot commented Mar 14, 2021

Copy link
Copy Markdown

@netlify

netlify Bot commented Mar 15, 2021

Copy link
Copy Markdown

@lex111
lex111 merged commit 07ec381 into facebook:master Mar 15, 2021
@lex111

lex111 commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

@quanengineering seems good, thanks!

@lex111 lex111 added this to the v2.0.0-alpha.72 milestone Mar 15, 2021
@lex111 lex111 changed the title add Vietnamese translation feat(v2): add Vietnamese translation for classic theme Mar 16, 2021
@lex111 lex111 added the pr: new feature This PR adds a new API or behavior. label Mar 16, 2021
This was referenced Mar 17, 2021
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
* add Vietnamese translation

* remove original word from translation string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants