Skip to content

refactor(v2): add ExecutionEnvironment, BrowserOnly, isInternalUrl to type aliases#4387

Merged
slorber merged 1 commit into
facebook:masterfrom
armano2:types/type-aliases
Mar 12, 2021
Merged

refactor(v2): add ExecutionEnvironment, BrowserOnly, isInternalUrl to type aliases#4387
slorber merged 1 commit into
facebook:masterfrom
armano2:types/type-aliases

Conversation

@armano2

@armano2 armano2 commented Mar 10, 2021

Copy link
Copy Markdown
Contributor

Motivation

add missing ExecutionEnvironment, BrowserOnly, isInternalUrl to known type aliases

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

if it compiles its working

Related tickets

ref; #3424

@armano2
armano2 requested review from lex111 and slorber as code owners March 10, 2021 23:21
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 10, 2021
@netlify

netlify Bot commented Mar 10, 2021

Copy link
Copy Markdown

@armano2 armano2 changed the title types(v2): add ExecutionEnvironment, BrowserOnly, isInternalUrl to known type aliases types(v2): add ExecutionEnvironment, BrowserOnly, isInternalUrl to type aliases Mar 10, 2021
@netlify

netlify Bot commented Mar 10, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit b783178

https://deploy-preview-4387--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4387--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 12, 2021
@slorber slorber changed the title types(v2): add ExecutionEnvironment, BrowserOnly, isInternalUrl to type aliases refactor(v2): add ExecutionEnvironment, BrowserOnly, isInternalUrl to type aliases Mar 12, 2021
@slorber

slorber commented Mar 12, 2021

Copy link
Copy Markdown
Collaborator

👍

@slorber
slorber merged commit f51f219 into facebook:master Mar 12, 2021
@armano2
armano2 deleted the types/type-aliases branch March 12, 2021 15:15
@lex111 lex111 added this to the v2.0.0-alpha.72 milestone Mar 15, 2021
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants