fix(v2): PWA issues + improve docs#4377
Merged
Merged
Conversation
|
[V1] Deploy preview success Built with commit c235adb |
|
Deploy preview for docusaurus-2 ready! Built with commit c235adb |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4377--docusaurus-2.netlify.app/classic/ |
|
Size Change: +3.25 kB (+1%) Total Size: 567 kB
ℹ️ View Unchanged
|
slorber
marked this pull request as ready for review
March 10, 2021 15:32
slorber
changed the title
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
Merged
Closed
Closed
Closed
Closed
Closed
mrizwanashiq
pushed a commit
to mrizwanashiq/docusaurus
that referenced
this pull request
Jun 25, 2026
* debug pwa * more debugging logs + attempt to upgrade workbox * fix PWA ? * fix PWA ? * enable pwa debugging for deploy previews * try to fix the app installed issue? * try to fix appinstalled not firing * try to add related applications to the PWA manifest * attempt to fix related_applications * attempt to fix related_applications * attempt to fix related_applications * improve PWA strategies * improve PWA doc * refactor/cleanup registerSw * cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix PWA issues reported in Jest after installing a PWA on desktop/mobile.
Also affecting Docusaurus site and should fix #4291
Should also fix #3208
Reason: I believe the Workbox v6 had an undocumented breaking change in PrecacheController, reported this here: GoogleChrome/workbox#2774
Another issue: it seems the events beforeinstallprompt and appinstalled should not be used anymore 😅 yet we rely on this
https://developer.mozilla.org/en-US/docs/Web/API/Window/appinstalled_event
https://firt.dev/pwa-2021#pwa-installation-triggers
I added usage of a new API
navigator.getInstalledRelatedApps()(which is also only in Chrome afaik...) and also added a new useful default strategystandalonewhich basically means that the PWA is running as an installed app.Also improved the docs