refactor(v2): remove duplicated lodash dependencies and import only what needed

[armano2]

Motivation

I don't like duplicated packages in my projects

Lodash library is isntalled multiple times and used in incositent way there are files when in one place we are importing lodash and lodash.* instead of reusing it

docusaurus/packages/docusaurus-plugin-content-docs/src/sidebars.ts

Line 8 in 2a25124

import flatMap from 'lodash.flatmap';

docusaurus/packages/docusaurus-plugin-content-docs/src/sidebars.ts

Line 21 in 2a25124

import {mapValues, flatten, difference} from 'lodash';

This is also recommended action from lodash: https://lodash.com/per-method-packages and per method packages will no longer be available in v5

Does this PR introduce a breaking change?

• Yes
• No

[facebook-github-bot]

Hi @armano2!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[netlify]

[V1] Deploy preview success

Built with commit 23138e6

https://deploy-preview-4361--docusaurus-1.netlify.app

[netlify]

Deploy preview for docusaurus-2 ready!

Built with commit 23138e6

https://deploy-preview-4361--docusaurus-2.netlify.app

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[github-actions]

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟠 Performance	89
🟢 Accessibility	96
🟢 Best practices	100
🟢 SEO	100
🟢 PWA	95

Lighthouse ran on https://deploy-preview-4361--docusaurus-2.netlify.app/classic/

[slorber]

Thanks, agree with you that we have an inconsistent and legacy lodash usage to refactor, and. would also like to move out of the per-method packages.

However I'm not sure this refactor is something we want:

It looks simpler to me to use named imports everywhere.

Note we are not supposed to include Lodash in client-side bundles (ESLint is supposed to prevent that), so that does not seem bad.

[armano2]

However I'm not sure this refactor is something we want:

@slorber ok i updated it to named imports and aligned required version of lodash across all packages

[slorber]

thanks, LGTM 👍