Skip to content

polish(v2): [theme-classic] update French translation and base.json #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slorber merged 2 commits into from
Mar 8, 2021
Merged

polish(v2): [theme-classic] update French translation and base.json #4358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e102fc2
Update fr.json
MisterFISHUP Mar 6, 2021
5cd28cd
Update base.json
MisterFISHUP Mar 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docusaurus-theme-classic/codeTranslations/base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"theme.CodeBlock.copied": "Copied",
"theme.CodeBlock.copied___DESCRIPTION": "The copied button label on code blocks",
"theme.CodeBlock.copy": "Copy",
"theme.CodeBlock.copy___DESCRIPTION": "The copy button label on code blocks",
"theme.CodeBlock.copyButtonAriaLabel": "Copy code to clipboard",
"theme.CodeBlock.copyButtonAriaLabel___DESCRIPTION": "The ARIA label for copy code blocks button",
"theme.CodeBlock.copy___DESCRIPTION": "The copy button label on code blocks",
Comment on lines +7 to -9

@slorber slorber Mar 8, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base is auto-generated so you should not update it, it will be reverted anyway

Will see how to update the auto-gen script to fix this, thanks!

"theme.NotFound.p1": "We could not find what you were looking for.",
"theme.NotFound.p1___DESCRIPTION": "The first paragraph of the 404 page",
"theme.NotFound.p2": "Please contact the owner of the site that linked you to the original URL and let them know their link is broken.",
Expand Down
10 changes: 5 additions & 5 deletions packages/docusaurus-theme-classic/codeTranslations/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
"theme.Playground.result": "Résultat",
"theme.PwaReloadPopup.closeButtonAriaLabel": "Fermer",
"theme.PwaReloadPopup.info": "Nouvelle version disponible",
"theme.PwaReloadPopup.refreshButtonText": "Rafraichir",
"theme.PwaReloadPopup.refreshButtonText": "Rafraîchir",
"theme.SearchBar.label": "Chercher",
"theme.SearchPage.algoliaLabel": "Recharche Algolia",
"theme.SearchPage.documentsFound.plurals": "One document found|{count} documents found",
"theme.SearchPage.documentsFound.plurals": "Un document trouvé|{count} documents trouvés",
"theme.SearchPage.emptyResultsTitle": "Rechercher dans la documentation",
"theme.SearchPage.existingResultsTitle": "Rechercher des résultats pour \"{query}\"",
"theme.SearchPage.existingResultsTitle": "Résultats de recherche pour « {query} »",

@slorber slorber Mar 8, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense thanks

"theme.SearchPage.fetchingNewResults": "Chargement de nouveaux résultats...",
"theme.SearchPage.inputLabel": "Chercher",
"theme.SearchPage.inputPlaceholder": "Tapez votre recherche ici",
Expand All @@ -29,7 +29,7 @@
"theme.blog.post.plurals": "Un article|{count} articles",
"theme.blog.post.readMore": "Lire plus",
"theme.blog.post.readingTime.plurals": "Une minute de lecture|{readingTime} minutes de lecture",
"theme.blog.tagTitle": "{nPosts} taggés avec \"{tagName}\"",
"theme.blog.tagTitle": "{nPosts} tagués avec « {tagName} »",

@slorber slorber Mar 8, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not easy to translate the "tag" concept in french. Not sure "taguer" verb is the best as imho it's more relevant for street art, but tagger is not great either 🤔 will merge this but if we have a better translation later we may revisit

@slorber slorber Mar 8, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will note to add plurals syntax for this title

@MisterFISHUP MisterFISHUP Mar 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noting the plural agreement issue :)
taggés -> tagués is just a more adaptive spelling that reflects the pronunciation if I'm not mistaken.

"theme.common.editThisPage": "Éditer cette page",
"theme.common.headingLinkTitle": "Lien direct vers le titre",
"theme.common.skipToMainContent": "Aller au contenu principal",
Expand All @@ -49,7 +49,7 @@
"theme.lastUpdated.atDate": " le {date}",
"theme.lastUpdated.byUser": " par {user}",
"theme.lastUpdated.lastUpdatedAtBy": "Dernière mise à jour{atDate}{byUser}",
"theme.tags.tagsListLabel": "Tags:",
"theme.tags.tagsListLabel": "Tags :",
"theme.tags.tagsPageLink": "Voir tous les tags",
"theme.tags.tagsPageTitle": "Tags"
}