Skip to content

polish(v2): [theme-classic] add Chinese translations (zh-Hant & zh-Hans)#4356

Merged
slorber merged 1 commit into
facebook:masterfrom
MisterFISHUP:zh-Hant-and-Hans-translations
Mar 8, 2021
Merged

polish(v2): [theme-classic] add Chinese translations (zh-Hant & zh-Hans)#4356
slorber merged 1 commit into
facebook:masterfrom
MisterFISHUP:zh-Hant-and-Hans-translations

Conversation

@MisterFISHUP

Copy link
Copy Markdown
Contributor

Motivation

I like this project and would like to contribute by adding zh-Hant and zh-Hans translations.

zh-Hant is for traditional Chinese (eg: Taiwan, Hong Kong, Macao) and zh-Hans for simplified Chinese (eg: PRC, Singapore).

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

N/A

Related PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 6, 2021
@netlify

netlify Bot commented Mar 6, 2021

Copy link
Copy Markdown

@netlify

netlify Bot commented Mar 6, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 34c1da9

https://deploy-preview-4356--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Mar 6, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4356--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 8, 2021
@slorber

slorber commented Mar 8, 2021

Copy link
Copy Markdown
Collaborator

thanks :)

Not really able to review this properly but let's merge and see if users provide feedbacks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants