Skip to content

fix(v2): always extract translations from site/src#4345

Merged
slorber merged 2 commits into
masterfrom
slorber/extract-translations-from-src
Mar 4, 2021
Merged

fix(v2): always extract translations from site/src#4345
slorber merged 2 commits into
masterfrom
slorber/extract-translations-from-src

Conversation

@slorber

@slorber slorber commented Mar 4, 2021

Copy link
Copy Markdown
Collaborator

Motivation

Translations should always be extracted from website/src as it's were most React components will end up.

Fixes #4341

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 4, 2021
@slorber slorber requested a review from lex111 as a code owner March 4, 2021 11:59
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 4, 2021
@netlify

netlify Bot commented Mar 4, 2021

Copy link
Copy Markdown

[V1] Deploy preview success

Built with commit 0b87fdc

https://deploy-preview-4345--docusaurus-1.netlify.app

@netlify

netlify Bot commented Mar 4, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built with commit 0b87fdc

https://deploy-preview-4345--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Mar 4, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 86
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4345--docusaurus-2.netlify.app/classic/

@github-actions

github-actions Bot commented Mar 4, 2021

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@netlify

netlify Bot commented Mar 4, 2021

Copy link
Copy Markdown

[V1] Deploy preview success

Built with commit a56c1d7

https://deploy-preview-4345--docusaurus-1.netlify.app

@netlify

netlify Bot commented Mar 4, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built with commit a56c1d7

https://deploy-preview-4345--docusaurus-2.netlify.app

@slorber slorber merged commit 6fc6cfe into master Mar 4, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 4, 2021
@slorber slorber deleted the slorber/extract-translations-from-src branch August 17, 2021 17:50
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
* ensure translation extractor extract translations from site/src

* commit typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translations API only seems to be working for "src/pages" directory

3 participants