Skip to content

polish(v2): Add more tags translations - #4275

Merged
slorber merged 2 commits into
masterfrom
slorber/missing-translation-tags
Feb 23, 2021
Merged

polish(v2): Add more tags translations#4275
slorber merged 2 commits into
masterfrom
slorber/missing-translation-tags

Conversation

@slorber

@slorber slorber commented Feb 23, 2021

Copy link
Copy Markdown
Collaborator

Motivation

As part of the first Docusaurus LTR / Farsi site here: massoudmaboudi/datagit#5

I noted that some tags related translations were missing, so let's add them.

Using the theme.tags namespace because we'll reuse it for doc tags later

@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Feb 23, 2021
@slorber
slorber requested a review from lex111 as a code owner February 23, 2021 14:57
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 23, 2021
"theme.blog.post.paginator.olderPost": "Предыдущий пост",
"theme.blog.post.readMore": "Читать дальше",
"theme.blog.tags": "Теги:",
"theme.tags.tagsPageLink": "Просмотреть все теги",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lex111 going to merge now but feel free to edit if google translate failed for this string ;)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@netlify

netlify Bot commented Feb 23, 2021

Copy link
Copy Markdown

[V1] Deploy preview success

Built with commit a7cd896

https://deploy-preview-4275--docusaurus-1.netlify.app

@github-actions

github-actions Bot commented Feb 23, 2021

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 544 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87 kB 0 B
website/build/assets/js/main.********.js 370 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.5 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.6 kB 0 B

compressed-size-action

@netlify

netlify Bot commented Feb 23, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built with commit a7cd896

https://deploy-preview-4275--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Feb 23, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4275--docusaurus-2.netlify.app/classic/

@slorber
slorber merged commit 2788efc into master Feb 23, 2021
"theme.blog.tags": "Tags:",
"theme.tags.tagsPageLink": "View All Tags",
"theme.tags.tagsPageTitle": "Tags",
"theme.tags.tagsListLabel": "Tags:",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like duplicate to me, colon should not be a apart of translation string which will allow to reuse the 18n string.

@slorber

slorber commented Feb 24, 2021 via email

Copy link
Copy Markdown
Collaborator Author

@Simek

Simek commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

I think some languages add a space or not before For RTL the : is on the other side

@slorber In my opinion that's the reason why colon should be separated (and placed in the separate node/tag), so the RTL conversion handle most of changes like that automatically for the users. 🙂

But to be honest I have only the experience with maintain the EU only multilingual sites, so I have not much RTL experience.

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber
slorber deleted the slorber/missing-translation-tags branch August 17, 2021 17:59
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
* Add blog tags translations

* Improve Ru translation

Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants