Skip to content

Update command to check yarn installation#4170

Merged
lex111 merged 1 commit into
facebook:masterfrom
jlin27:master
Feb 3, 2021
Merged

Update command to check yarn installation#4170
lex111 merged 1 commit into
facebook:masterfrom
jlin27:master

Conversation

@jlin27

@jlin27 jlin27 commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

As listed yarn version works but throws an error. This PR updates the command that checks the install to be yarn --version per the Yarn docs

As listed `yarn version` doesn't work. According to [Yarn docs](https://classic.yarnpkg.com/en/docs/install#mac-stable), the command to check install should be `yarn --version`.
@jlin27 jlin27 requested review from lex111 and slorber as code owners February 3, 2021 19:48
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 3, 2021
@jlin27 jlin27 changed the title Update check yarn installation command Update command to check yarn installation Feb 3, 2021
@netlify

netlify Bot commented Feb 3, 2021

Copy link
Copy Markdown

@netlify

netlify Bot commented Feb 3, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 38caff3

https://deploy-preview-4170--docusaurus-2.netlify.app

@github-actions

github-actions Bot commented Feb 3, 2021

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 60
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4170--docusaurus-2.netlify.app/classic/

@github-actions

github-actions Bot commented Feb 3, 2021

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.7 kB 0 B
website/build/assets/js/main.********.js 109 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB 0 B

compressed-size-action

@lex111 lex111 merged commit 4d3573d into facebook:master Feb 3, 2021
@lex111

lex111 commented Feb 3, 2021

Copy link
Copy Markdown
Contributor

@jlin27 thanks!

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
As listed `yarn version` doesn't work. According to [Yarn docs](https://classic.yarnpkg.com/en/docs/install#mac-stable), the command to check install should be `yarn --version`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants