Skip to content

chore(v2): Update workbox to v6#4120

Merged
slorber merged 1 commit into
facebook:masterfrom
RDIL:workbox-6
Jan 29, 2021
Merged

chore(v2): Update workbox to v6#4120
slorber merged 1 commit into
facebook:masterfrom
RDIL:workbox-6

Conversation

@RDIL

@RDIL RDIL commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

Motivation

Its an update, updates are usually cool

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Looks to work just fine

Related PRs

n/a

@RDIL RDIL requested review from lex111 and slorber as code owners January 28, 2021 17:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 28, 2021
@netlify

netlify Bot commented Jan 28, 2021

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

Size Change: 0 B

Total Size: 28.8 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.8 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.87 kB 0 B

compressed-size-action

@netlify

netlify Bot commented Jan 28, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit c0873f1

https://deploy-preview-4120--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 85
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4120--docusaurus-2.netlify.app/classic/

const registrations = await navigator.serviceWorker.getRegistrations();
if (debug && registrations.length > 0) {
console.log(
`[Docusaurus-PWA][registerSW]: unregister service workers`,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just makes casing consistent with the file name

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jan 29, 2021
@slorber slorber changed the title feat(v2): Update workbox to v6 chore(v2): Update workbox to v6 Jan 29, 2021
@slorber

slorber commented Jan 29, 2021

Copy link
Copy Markdown
Collaborator

Thanks, seems to keep working 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants