Skip to content

feat(v2): default canonical urls#4109

Merged
slorber merged 1 commit into
masterfrom
slorber/default-canonical-urls
Jan 28, 2021
Merged

feat(v2): default canonical urls#4109
slorber merged 1 commit into
masterfrom
slorber/default-canonical-urls

Conversation

@slorber

@slorber slorber commented Jan 27, 2021

Copy link
Copy Markdown
Collaborator

Motivation

You shouldn't use <Layout permalink=""/> for your homepage (like we currently had for Docusaurus 2 website), the canonical URL should rather be inferred from site URL + current page path.

This works better particularly for canonical URLs on translated pages (the french homepage canonical URL is /fr not /

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

this should fix an SEO / i18n issue reported by https://technicalseo.com/tools/hreflang/ due to having bad canonical URLs on localized site homepage

image

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Jan 27, 2021
@slorber slorber requested a review from lex111 as a code owner January 27, 2021 19:06
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 27, 2021
@netlify

netlify Bot commented Jan 27, 2021

Copy link
Copy Markdown

[V1] Deploy preview success

Built with commit 7bf5193

https://deploy-preview-4109--docusaurus-1.netlify.app

@github-actions

Copy link
Copy Markdown

Size Change: -2 B (0%)

Total Size: 28.8 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB -2 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.87 kB 0 B

compressed-size-action

@netlify

netlify Bot commented Jan 27, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built with commit 7bf5193

https://deploy-preview-4109--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4109--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit beddecb into master Jan 28, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants