Skip to content

fix(v2): fix/enhance minor i18n issues reported#4092

Merged
slorber merged 6 commits into
masterfrom
slorber/i18n-review-1
Jan 22, 2021
Merged

fix(v2): fix/enhance minor i18n issues reported#4092
slorber merged 6 commits into
masterfrom
slorber/i18n-review-1

Conversation

@slorber

@slorber slorber commented Jan 22, 2021

Copy link
Copy Markdown
Collaborator

Motivation

Minor i18n fixes reported here: #3317 (comment)

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

preview + SEO tools

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jan 22, 2021
@slorber slorber requested a review from lex111 as a code owner January 22, 2021 18:34
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 22, 2021
@netlify

netlify Bot commented Jan 22, 2021

Copy link
Copy Markdown

[V1] Deploy preview success

Built with commit f80b58d

https://deploy-preview-4092--docusaurus-1.netlify.app

@netlify

netlify Bot commented Jan 22, 2021

Copy link
Copy Markdown

Deploy preview for docusaurus-2 ready!

Built with commit f80b58d

https://deploy-preview-4092--docusaurus-2.netlify.app

@github-actions

Copy link
Copy Markdown

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4092--docusaurus-2.netlify.app/classic/

@github-actions

Copy link
Copy Markdown

Size Change: -2 B (0%)

Total Size: 27.1 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.9 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.02 kB -1 B (0%)

compressed-size-action

@slorber slorber merged commit 869ebe7 into master Jan 22, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/i18n-review-1 branch August 17, 2021 17:50
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
* fix comment

* allow to pass custom classname in navbar items

* Add IconLanguage comp to dropdown

* do not trim htmlLang

* Add initial hreflang SEO support

* doc hreflang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants