Skip to content

docs(v1): fix typo on Add Versions doc page#3651

Merged
lex111 merged 1 commit into
facebook:masterfrom
egbobright:patch-1
Oct 28, 2020
Merged

docs(v1): fix typo on Add Versions doc page#3651
lex111 merged 1 commit into
facebook:masterfrom
egbobright:patch-1

Conversation

@egbobright

Copy link
Copy Markdown
Contributor

The file generated when you run npm run examples versions is a versions.json file and not a version.js file

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

The file generated when you run `npm run examples versions` is a versions.json file and not a version.js file
@egbobright egbobright requested a review from slorber as a code owner October 28, 2020 06:51
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Hi @egbobright!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit b4b1a40

https://deploy-preview-3651--docusaurus-2.netlify.app

@slorber

slorber commented Oct 28, 2020

Copy link
Copy Markdown
Collaborator

thanks

please sign the CLA otherwise I'm not able to merge this PR

@egbobright

Copy link
Copy Markdown
Contributor Author

thanks

please sign the CLA otherwise I'm not able to merge this PR

I have just signed it.

Thank you.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 28, 2020
@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 changed the title Update tutorial-version.md docs(v1): fix typo on Add Versions doc page Oct 28, 2020
@lex111 lex111 merged commit 2aae771 into facebook:master Oct 28, 2020
@lex111

lex111 commented Oct 28, 2020

Copy link
Copy Markdown
Contributor

@egbobright thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: ignore This PR is not meaningful enough to appear in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants