Skip to content

fix(v2): restore infinite scroll pagination on search page#3639

Merged
slorber merged 1 commit into
masterfrom
lex111/algolia-fix-pagination
Oct 26, 2020
Merged

fix(v2): restore infinite scroll pagination on search page#3639
slorber merged 1 commit into
masterfrom
lex111/algolia-fix-pagination

Conversation

@lex111

@lex111 lex111 commented Oct 25, 2020

Copy link
Copy Markdown
Contributor

Motivation

PR #3604 broke the infinite scroll pagination functionality on the search page, because the page is always 0. To fix it we first need set facet refinements, and then query, page, etc.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 requested a review from slorber as a code owner October 25, 2020 22:24
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 25, 2020
@docusaurus-bot

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 0295ae0

https://deploy-preview-3639--docusaurus-2.netlify.app

@slorber

slorber commented Oct 26, 2020

Copy link
Copy Markdown
Collaborator

ah ok 😅 thanks, this algolia api is a bit unintuitive to me

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 26, 2020
@slorber slorber merged commit c82800e into master Oct 26, 2020
@lex111 lex111 deleted the lex111/algolia-fix-pagination branch October 26, 2020 22:05
@lex111 lex111 added this to the v2.0.0-alpha.67 milestone Nov 17, 2020
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants