Skip to content

docs(v1): added drone for 1.0 #3491#3538

Merged
slorber merged 2 commits into
facebook:masterfrom
aakhtar3:master
Oct 5, 2020
Merged

docs(v1): added drone for 1.0 #3491#3538
slorber merged 2 commits into
facebook:masterfrom
aakhtar3:master

Conversation

@aakhtar3

@aakhtar3 aakhtar3 commented Oct 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

Add drone support for 1.0

Have you read the Contributing Guidelines on pull requests?

Yes

Related PRs

#3492

@aakhtar3 aakhtar3 requested a review from slorber as a code owner October 5, 2020 03:35
@aakhtar3

aakhtar3 commented Oct 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@slorber is this the correct place?

I don't see this in the source code
https://docusaurus.io/docs/en/publishing#hosting-on-zeit-now

Also checkout this issue #3537

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 5, 2020
@docusaurus-bot

docusaurus-bot commented Oct 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit a587d8e

https://deploy-preview-3538--docusaurus-2.netlify.app

@slorber

slorber commented Oct 5, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Hi @aakhtar3, yes this is the correct place, and can be seen in the v1 deploy preview here:
https://deploy-preview-3538--docusaurus-2.netlify.app/v1/docs/en/next/publishing#using-drone

As website-1.x/docs is not the "next version", not released yet (ie will be scheduler to appear at 1.14.7).
As we don't often release v1 anymore, and this is not related to code, it's worth backporting those changes so that they appear immediately on the website. Will do it, as the docs fallback versioning system is a bit confusing (had to backport in 1.14.5)

@slorber slorber merged commit 6637e1d into facebook:master Oct 5, 2020
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 5, 2020
mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
@aakhtar3 @slorber
docs(v1): added drone for 1.0 facebook#3491 (facebook#3538)
3b7e659 
* docs(v1): added drone for 1.0 facebook#3491

* Update getting-started-publishing.md

Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slorber slorber Awaiting requested review from slorber

Assignees

No one assigned

Labels

CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aakhtar3 @docusaurus-bot @slorber @facebook-github-bot