Skip to content

fix(v2): wait plugin watching approach#1390

Merged
endiliey merged 8 commits into
masterfrom
wait
Apr 25, 2019
Merged

fix(v2): wait plugin watching approach#1390
endiliey merged 8 commits into
masterfrom
wait

Conversation

@yangshun

@yangshun yangshun commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

Motivation

Fix wait plugin hanging on certain OS and platform

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

  • CI passes

Related PRs

#1389

@yangshun yangshun requested a review from endiliey as a code owner April 24, 2019 22:58
@docusaurus-bot

docusaurus-bot commented Apr 24, 2019

Copy link
Copy Markdown
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 4c14ba7

https://deploy-preview-1390--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 24, 2019
@endiliey endiliey self-assigned this Apr 25, 2019
@endiliey endiliey merged commit 6d53264 into master Apr 25, 2019
@endiliey endiliey deleted the wait branch April 25, 2019 13:18
Comment thread .netlify/state.json
@@ -0,0 +1,3 @@
{
"siteId": "9e1ff559-4405-4ebe-8718-5e21c0774bc8"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh god i accidentally added this 🤦‍♂️

mrizwanashiq pushed a commit to mrizwanashiq/docusaurus that referenced this pull request Jun 25, 2026
* fix(v2): wait plugin watching approach

* Update package.json

* rush fix

* Use 2. x branch

* Update WaitPlugin.js

* yarn.lock

* use polling

* switch chokidar w-> wait-on npm package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants