Skip to content

(exa PR) 1064: Add -A option for more compatibility with ls#43

Merged
sbatial merged 11 commits into
mainfrom
pr-1064
Jul 30, 2023
Merged

(exa PR) 1064: Add -A option for more compatibility with ls#43
sbatial merged 11 commits into
mainfrom
pr-1064

Conversation

@cafkafk

@cafkafk cafkafk commented Jul 29, 2023

Copy link
Copy Markdown
Member

@cafkafk cafkafk changed the title (exa PR) 1064 (exa PR) 1064: Add -A option for more compatibility with ls Jul 29, 2023
@sbatial sbatial mentioned this pull request Jul 29, 2023
@sbatial sbatial self-assigned this Jul 29, 2023
@sbatial

sbatial commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

I arrived at an implementation that does what we want and is pretty concise imo

One thing I'd like your opinion on: I think it makes sense to not err when --tree --all --all is used but to fall back to --tree --all.
I find it a bit pedantic for a tool to be very much aware of the problem but not to try and react to it
(I'd do that in a different PR though. does not fall in the scope of this one)

@cafkafk

cafkafk commented Jul 30, 2023

Copy link
Copy Markdown
Member Author

I think it makes sense to not err when --tree --all --all is used but to fall back to --tree --all.

I agree!

I find it a bit pedantic for a tool to be very much aware of the problem but not to try and react to it

Wym by this?

@cafkafk

cafkafk commented Jul 30, 2023

Copy link
Copy Markdown
Member Author

Your changes seem to work without breaking anything, and cargo test works. Testing the -A flag also seems to work for me.

Is this ready to merge?

@cafkafk cafkafk linked an issue Jul 30, 2023 that may be closed by this pull request
@sbatial

sbatial commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

I find it a bit pedantic for a tool to be very much aware of the problem but not to try and react to it

Wym by this?

Well when --tree --all --all is used right now an error is thrown that that is not possible.
But we know why it is not possible (as far as I'm aware): it would lead to infinite recursion.
And we also know a (imo) solution that is reasonable to assume that that is what the user tried to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

About the -A flag

3 participants