Use chrono#227
Merged
Merged
Conversation
cafkafk
requested changes
Sep 9, 2023
cafkafk
left a comment
cafkafk
left a comment
Member
There was a problem hiding this comment.
Thanks for moving this!
The commit summaries should follow conventional commits, see https://github.com/eza-community/eza/pull/149/files for a summary of what is expected.
- Improve compatibility with other OSes, timezone are handled for us - Reduce significantly the code to render date and time
Contributor
Author
|
This should be good now! |
cafkafk
approved these changes
Sep 11, 2023
cafkafk
left a comment
cafkafk
left a comment
Member
There was a problem hiding this comment.
This seems to work, CI, integration tests and my attempts at testing it locally indicate it as working. Ty for the PR ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New PR based on #58.