Skip to content

(exa PR) 1188: Moving actions to dtolnay's version#14

Merged
cafkafk merged 1 commit into
mainfrom
pr-1188
Jul 30, 2023
Merged

(exa PR) 1188: Moving actions to dtolnay's version#14
cafkafk merged 1 commit into
mainfrom
pr-1188

Conversation

@cafkafk

@cafkafk cafkafk commented Jul 29, 2023

Copy link
Copy Markdown
Member

@cafkafk cafkafk changed the title (exa PR) 1188 (exa PR) 1188: Moving actions to dtolnay's version Jul 29, 2023
@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks

@sbatial sbatial left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1stDimension's argument does make sense:

Let's switch to dtolnay's version of action. This route was taken here. It's code inside rust's regex crate. If it is good enough for them it will work for us.

And they are still using it today: https://github.com/rust-lang/regex/blob/master/.github/workflows/ci.yml#L80

I say we merge it and try to confirm that it does not break anything (the action does run on main anyways, no?)

I don't know if the checks for this PR would take the updated action if we merged main back into this branch but that would also be a viable option to have them run before going into main

@cafkafk

cafkafk commented Jul 30, 2023

Copy link
Copy Markdown
Member Author

(the action does run on main anyways, no?)

Only one way to find out :D (we should get a development branch one of these days)

@cafkafk cafkafk merged commit c978469 into main Jul 30, 2023
@cafkafk

cafkafk commented Jul 30, 2023

Copy link
Copy Markdown
Member Author

@sbatial

sbatial commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

Looks like it 👍

@sbatial sbatial deleted the pr-1188 branch July 30, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants