Conversation
There was a problem hiding this comment.
@1stDimension's argument does make sense:
Let's switch to dtolnay's version of action. This route was taken here. It's code inside rust's regex crate. If it is good enough for them it will work for us.
And they are still using it today: https://github.com/rust-lang/regex/blob/master/.github/workflows/ci.yml#L80
I say we merge it and try to confirm that it does not break anything (the action does run on main anyways, no?)
I don't know if the checks for this PR would take the updated action if we merged main back into this branch but that would also be a viable option to have them run before going into main
Only one way to find out :D (we should get a development branch one of these days) |
|
Looks like it 👍 |
ogham/exa#1188