Skip to content

feat!: remove special case for _ prefixed files in windows#1233

Open
jschpp wants to merge 1 commit into
eza-community:mainfrom
jschpp:remove-underscore-ignore
Open

feat!: remove special case for _ prefixed files in windows#1233
jschpp wants to merge 1 commit into
eza-community:mainfrom
jschpp:remove-underscore-ignore

Conversation

@jschpp

@jschpp jschpp commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

On windows files prefixed with a _ were being ignored because some old applications used those files as pseudo dotfiles.

This was controversial when the feature was added way back when: ogham/exa#820 (review)

Fixes #1220

On windows files prefixed with a `_` were being ignored because some old
applications used those files as pseudo dotfiles.

This was controversial when the feature was added way back when:
ogham/exa#820 (review)

Fixes eza-community#1220

@cafkafk cafkafk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need some discussion before being implemented

@jschpp

jschpp commented Nov 14, 2024

Copy link
Copy Markdown
Contributor Author

Yeah. I completely agree with you there.
I'm not sure if removing is the right way to go forward here myself.
I tried hiding this behind a cmd flag but couldn't quite get it to work since I'd need to add something like git_ignoring which will have to be included pretty much everywhere since it would touch the Files API

@fgimian

fgimian commented Dec 28, 2024

Copy link
Copy Markdown

I personally vote that this behaviour be removed completely as per this PR. The current behaviour is very unexpected and unusual, so much so that it feels like a bug. 😊

@jack-mil

Copy link
Copy Markdown

Any more thoughts from maintainers about getting this merged? Would love to see this annoyance dealt with.

@cafkafk cafkafk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the easiest way to move forward with this would be to allow the old behavior via a flag, I do think we could probably just get rid of this as a default, but it was probably added because someone found it valuable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

bug: eza hides files beginning with __ for python projects on Windows

4 participants