fix: include deps as private in pkg-config#6
Merged
Conversation
…d to the application.
zshipko
approved these changes
Nov 3, 2023
zshipko
left a comment
zshipko
left a comment
Contributor
There was a problem hiding this comment.
I'm not super well-versed in pkg-config stuff, but looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They do not need to be exposed to the application so I think this is best practice. The dynamic pkg-config also able to use the jsoncpp package as a dep instead of adding its linking flags manually.