Skip to content

docs: add getting started#13

Merged
G4Vi merged 4 commits into
mainfrom
docs-getting-started
Dec 6, 2023
Merged

docs: add getting started#13
G4Vi merged 4 commits into
mainfrom
docs-getting-started

Conversation

@G4Vi

@G4Vi G4Vi commented Dec 6, 2023

Copy link
Copy Markdown
Contributor

For internal editing convenience, the code from the getting started is here

@G4Vi G4Vi requested a review from zshipko December 6, 2023 19:11

@zshipko zshipko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but looks good!

Comment thread README.md Outdated
Plug-ins may optionally take a configuration object. This is a static way to configure the plug-in. Our count-vowels plugin takes an optional configuration to change out which characters are considered vowels. Example:

```cpp
// #include ...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth just using #include <extism.h> here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to #include <extism.hpp>

@G4Vi G4Vi merged commit 9477fef into main Dec 6, 2023
@G4Vi G4Vi mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants