Limit the number of notifications shown simultaneously

.github/workflows/build.yml

@@ -56,7 +56,7 @@ jobs:
       uses: codecov/test-results-action@v1
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
-        files: build/test/**/*.junit.xml
+        files: build/test/result.junit.xml
 
     - name: Bundle
       run: corepack yarn build-js

.github/workflows/check-pr.yml

@@ -56,4 +56,4 @@ jobs:
       uses: codecov/test-results-action@v1
       with:
         token: ${{ secrets.CODECOV_TOKEN }}
-        files: build/test/**/*.junit.xml
+        files: build/test/result.junit.xml

ext/options.css

@@ -43,7 +43,7 @@ input {
   height: 100%;
 
   &[type="number"] {
-    text-align: var(--align-end);
+    text-align: right;
   }
   &[type="reset"] {
     height: var(--in-content-button-height);

ext/options.nolint.css

@@ -2,5 +2,6 @@
 /* @see https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization#predefined_messages */
 :root {
   --direction: __MSG_@@bidi_dir__;
+  --align-start: __MSG_@@bidi_start_edge__;
   --align-end: __MSG_@@bidi_end_edge__;
-}
+}

src/ghosttext-adaptor/email_editor.ts

@@ -20,15 +20,16 @@ export class EmailEditor implements IClientEditor, IStatusIndicator {
     private readonly options: ClientOptions,
   ) {}
 
-  update(status: ClientStatus): Promise<void> {
+  async update(status: ClientStatus): Promise<void> {
     const icon = imageForStatus(status)
+    const isNewStatus = status !== (this.lastStatus ?? "inactive")
 
-    if (status !== (this.lastStatus ?? "inactive")) {
-      this.notificationTray.showNotification(icon, messageForStatus(status))
-    }
     this.lastStatus = status
 
-    return this.composeWindow.setIcon(icon)
+    await Promise.all([
+      isNewStatus && this.notificationTray.showNotification(icon, messageForStatus(status)),
+      this.composeWindow.setIcon(icon),
+    ])
   }
 
   async getState(): Promise<EmailState> {

src/thunderbird/background_util/notification_tray.ts

@@ -2,9 +2,13 @@ import type { INotificationTray } from "src/ghosttext-adaptor"
 import type { MessageId } from "src/util"
 import type { ManifestInfo } from "."
 
+/** Wraps the Notification API */
 export class NotificationTray implements INotificationTray {
   static isSingleton = true
 
+  /** Maximum number of notifications to show simultaneously */
+  private readonly slotCount = 5
+  private lastId = 0
   private title: string | undefined
 
   constructor(
@@ -13,7 +17,8 @@ export class NotificationTray implements INotificationTray {
   ) {}
 
   async showNotification(iconUrl: string, messageId: MessageId): Promise<void> {
-    await this.messenger.notifications.create(this.makeNotification(iconUrl, messageId))
+    const opts = this.makeNotification(iconUrl, messageId)
+    await this.messenger.notifications.create(this.makeId(), opts)
   }
 
   private makeNotification(iconUrl: string, messageId: MessageId): messenger.notifications.CreateNotificationOptions {
@@ -25,4 +30,9 @@ export class NotificationTray implements INotificationTray {
       message: this.messenger.i18n.getMessage(messageId),
     }
   }
+
+  private makeId(): string {
+    this.lastId = (this.lastId + 1) % this.slotCount
+    return `NotificationTray-${this.lastId}`
+  }
 }

tsconfig.json

@@ -31,19 +31,31 @@
     "favicon": "ext/blue.svg",
     "router": "structure",
     "searchInDocuments": true,
+    "readme": "none",
     "githubPages": false,
     "customJs": "doc/res/typedoc.cjs",
+    "excludePrivate": false,
+    "includeHierarchySummary": false,
+    "excludeReferences": true,
+    "modifierTags": [
+      "@file"
+    ],
+    "sluggerConfiguration": {
+      "lowercase": true
+    },
     "ignoredHighlightLanguages": [
       "mermaid"
     ],
     "entryPoints": [
+      "./src/*/*/index.ts",
       "./src/*/index.ts"
     ],
     "projectDocuments": [
       "doc/*.md",
       "ext/*.md",
       "CONTRIBUTING.md",
-      "BUILDING.md"
+      "BUILDING.md",
+      "README.md"
     ],
     "plugin": [
       "typedoc-plugin-mdn-links"