4.19.0 breaks passing new URL() into res.redirect(...)

Understandably, res.redirect(...) should take a string. But for years we have been successfully passing a new URL(). We can certainly fix this on our side, but wanted to give a heads-up that this change might cause others to run into the same thing.

Error ultimately is thrown here:

reponse.js:915
var lowerLoc = loc.toLowerCase();

Ahhhh, yep that is not covered in the tests. I can prep a patch for that.

@kavika-1

@kavika-1 Do you have a code snippet example of what you are doing so I can make sure this covers your case?

fix #5554 passing URL instances with new locataion encoding

Can you check the PR to ensure it would cover you? CI is failing because of #5552 but I can merge this all together for the patch if this will fix your report.

Example Code snippet, which should be fixed with this patch, thanks!

    const url = new URL(config.url);
    if (req.query.app) {
      url.searchParams.append('app', req.query.app);
    }
    res.redirect(url);

fix #5554 passing URL instances with new locataion encoding

Published with 4.19.1. Thanks for the quick report, this would certainly have been something lots of folks hit.

@wesleytodd

Amazing turnaround, thanks @wesleytodd!

Ahah nice. I was hit by this and double checked the documentation. Clearly res.location accepts only a string so I patched my code to pass url.href instead of the url object and I could merge 4.19.0 just to discover a PR upgrading to 4.19.1 moments later for exactly this issue 😊

Thanks for your reactivity!

Cheers,
David

Navigation Menu

Repository navigation

4.19.0 breaks passing new URL() into res.redirect(...) #5554

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

4.19.0 breaks passing new URL() into res.redirect(...) #5554

Description

Activity

wesleytodd commented on Mar 20, 2024

wesleytodd commented on Mar 20, 2024

wesleytodd commented on Mar 20, 2024

kavika-1 commented on Mar 20, 2024

wesleytodd commented on Mar 20, 2024

kavika-1 commented on Mar 20, 2024

ddolcimascolo commented on Mar 21, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions