Skip to content

fix(docker): drop the duplicate OPENROUTER_API_KEY entry from compose - #176

Closed
Nordalux wants to merge 1 commit into
every-app:mainfrom
Nordalux:fix/compose-duplicate-openrouter-key
Closed

Nordalux wants to merge 1 commit into
every-app:mainfrom
Nordalux:fix/compose-duplicate-openrouter-key

Conversation

@Nordalux

Copy link
Copy Markdown
Contributor

Problem

compose.yaml names OPENROUTER_API_KEY twice under environment::

      # Optional: AI features (SAM, onboarding chat). Without this the setup
      # gate in the app asks for the key, but nothing here would forward it.
      - OPENROUTER_API_KEY=${OPENROUTER_API_KEY:-}
      ...
      # Optional: AI features (SAM, the in-app SEO agent)
      - OPENROUTER_API_KEY=${OPENROUTER_API_KEY:-}
      - OPENROUTER_MODEL=${OPENROUTER_MODEL:-}

This is my fault. #428 had already generalised the passthrough with env_file: .env and listed the key next to OPENROUTER_MODEL. My #152 was merged on top a day later without a rebase, adding a second entry for the same variable.

Nothing is broken: Compose takes the last entry and both resolve to ${OPENROUTER_API_KEY:-}, so the rendered value is unchanged and no warning is emitted. But the duplicate is dead weight, and the comment above my entry now says the opposite of the truth — it claims nothing would forward the key, which stopped being the case the moment env_file landed.

Change

Remove my entry and its stale comment. Keep the one that sits with OPENROUTER_MODEL.

Verification

With a .env containing both variables, docker compose config renders the same values before and after:

      OPENROUTER_API_KEY: sk-or-test
      OPENROUTER_MODEL: some/model

pnpm ci:check passes.

Verified and tested by hand. The description was drafted with AI assistance — I'd rather let the diff do the talking than a long write-up.

every-app#428 had already generalised the passthrough with `env_file: .env` and listed
`OPENROUTER_API_KEY` alongside `OPENROUTER_MODEL`. My every-app#152 landed on top of it
without a rebase and added a second entry for the same variable, so
`environment:` now names it twice.

Compose takes the last entry, and both resolved to `${OPENROUTER_API_KEY:-}`,
so nothing was broken — but the duplicate is dead weight and the comment above
my entry is now wrong: it claims nothing would forward the key, which stopped
being true when `env_file` landed.

Remove my entry and keep the one that sits with `OPENROUTER_MODEL`.

`docker compose config` renders identical values for OPENROUTER_API_KEY and
OPENROUTER_MODEL before and after.
HasimEmre pushed a commit to HasimEmre/open-seo that referenced this pull request Jul 30, 2026
* Fix open-seo MCP auth discovery

* Refine MCP marketing page route and copy
@bensenescu

Copy link
Copy Markdown
Contributor

Hey,

Thanks for contributing!

For the next few months, I'm going to stop accepting external PRs.

Reviewing and testing them has been slowing down progress against our roadmap:
https://openseo.so/roadmap

Contributing through Issues
Right now, the best way to contribute is through creating quality "Issues" which are easier for me to review and prioritize right now.

Here is our updated contributing guide: https://github.com/every-app/open-seo/blob/main/docs/CONTRIBUTING.md

Converting, this PR to an issue would be the best way to get it prioritized.

You can use the the /simple-issue-description skill described in the guide to convert the PR to an issue.

ramonmnavarro-byte pushed a commit to ramonmnavarro-byte/open-seo that referenced this pull request Aug 25, 2026
* Fix open-seo MCP auth discovery

* Refine MCP marketing page route and copy
@bensenescu

Copy link
Copy Markdown
Contributor

Closing, we're not planning to take this one. Thanks!

@bensenescu bensenescu closed this Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants