Skip to content

ENG-3847: Make client comments clearer#8220

Merged
tvandort merged 3 commits into
mainfrom
ENG-3847
May 18, 2026
Merged

ENG-3847: Make client comments clearer#8220
tvandort merged 3 commits into
mainfrom
ENG-3847

Conversation

@tvandort
Copy link
Copy Markdown
Contributor

@tvandort tvandort commented May 18, 2026 •
edited by atlassian Bot
Loading

Ticket ENG-3847

Description Of Changes

Labels API Client comments as automated.

Steps to Confirm

  1. Leave a comment on a DSR as
  2. a root user
  3. a normal user
  4. an api client user

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@tvandort tvandort requested a review from a team as a code owner May 18, 2026 14:29
@tvandort tvandort requested review from lucanovera and removed request for a team May 18, 2026 14:29
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 18, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview May 18, 2026 2:30pm
fides-privacy-center Ignored Ignored May 18, 2026 2:30pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 9%
 6.93% (3173/45766) 6.34% (1680/26489) 4.79% (650/13543)
fides-js Coverage: 78%
 79.17% (1977/2497) 66.25% (1249/1885) 73.31% (349/476)
privacy-center Coverage: 85%
 82.53% (364/441) 79.74% (189/237) 74.07% (60/81)

@tvandort tvandort added this pull request to the merge queue May 18, 2026
Merged via the queue into main with commit 65d79a9 May 18, 2026
51 checks passed
@tvandort tvandort deleted the ENG-3847 branch May 18, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erosselli erosselli erosselli approved these changes

@lucanovera lucanovera Awaiting requested review from lucanovera lucanovera was automatically assigned from ethyca/frontend

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tvandort @erosselli