Repository navigation
Conversation
LouisTsai-Csie
left a comment
LouisTsai-Csie
left a comment
Contributor
There was a problem hiding this comment.
Hello Mario, I was reviewing this EIP today, leaving some comments
| | **New EVM gas refund** | | | | ||
| | **Patterns affecting pre-existing tests** | | | | ||
| | **New invariant on pre-existing tests** | | | | ||
| | **Transition-tool interface changes** | | | |
Contributor
There was a problem hiding this comment.
Do we need to add recent_root_references in the transition tool interface?
| | **New fork activation mechanism** | 1 | EIP states that an irregular state transition is required, but this is complex and potentially it is not necessary: We probably can simply deploy using the well known system contract deployment methods used for previous forks. Worth pushing back on the deployment method as it is probably an outdated specification requirement. | | ||
| | **Performance risks** | 1 | Requires testing worst-case block filled with transactions consuming block limit using `MAX_RECENT_ROOT_REFERENCES`. | | ||
| | **Security risks** | 0 | | | ||
| | **Unspecified behavior requiring cross-client consensus** | 0 | No major underspecification identified. | |
Contributor
There was a problem hiding this comment.
Some idea:
- opcode
0xB5currently conflicts with EIP-8141SIGDATACOPY(easy) - displayed FrameTx payload has not been synchronized with EIP-8141's current nested fees field (easy)
RECENT_ROOT_CODEis not finalized (medium)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft of the EIP-8272 complexity assessment, scored against the revision 2 checklist. For #72.