clients: wire HIVE_TARGET_GAS_LIMIT for besu, erigon, reth, ethrex - #1603
Merged
danceratopz merged 3 commits intoAug 31, 2026
Merged
Conversation
danceratopz
approved these changes
Aug 31, 2026
danceratopz
left a comment
Member
There was a problem hiding this comment.
Hey @MysticRyuujin, this LGTM.
Sorry for the commit noise here, I saw that nimbus-el wasn't added, before realizing that this flag was marked as deprecated and that nimbus doesn't support testing_buildBlockV1, so reverted that commit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass
HIVE_TARGET_GAS_LIMITto the client's target gas limit flag in the besu, erigon, reth, and ethrex wrappers. Only go-ethereum and nethermind consumed it before.--target-gas-limit--miner.gaslimit--builder.gaslimit--builder.gas-limitWhy
#1585 defaults
HIVE_TARGET_GAS_LIMITto 60,000,000 in rpc-compat so thattesting_buildBlockV1builds deterministic blocks across clients. A client that does not consume the variable keeps its own default and builds a different gas limit, which changes the block hash. Besu fails 2 of 4 buildBlockV1 tests on current execution-apis fixtures for this reason.Verification
Ran
rpc-compat/testing_buildBlockV1with besu (main), erigon and reth (glamsterdam-devnet-8 images) before and after, on both the current fixtures and the ethereum/execution-apis#867 Amsterdam fixtures:targetGasLimitin the payload attributes for Glamsterdam+ (fix: add slotNumber and targetGasLimit to testing_buildBlockV1 execution-apis#862), which node configuration cannot supply.--help; not exercised at runtime because ethrex cannot import the rpc-compat chain (Exit the client if on a pre merge fork lambdaclass/ethrex#5504).An alternative is to emit the value from hivechain's forkenv output. The sim-side default from #1585 already covers where the value comes from, so this PR only adds the client-side consumption.