Skip to content

clients: wire HIVE_TARGET_GAS_LIMIT for besu, erigon, reth, ethrex - #1603

Merged
danceratopz merged 3 commits into
ethereum:masterfrom
MysticRyuujin:target-gas-limit-clients
Aug 31, 2026
Merged

danceratopz merged 3 commits into
ethereum:masterfrom
MysticRyuujin:target-gas-limit-clients

Conversation

@MysticRyuujin

Copy link
Copy Markdown
Contributor

Summary

Pass HIVE_TARGET_GAS_LIMIT to the client's target gas limit flag in the besu, erigon, reth, and ethrex wrappers. Only go-ethereum and nethermind consumed it before.

client flag
besu --target-gas-limit
erigon --miner.gaslimit
reth --builder.gaslimit
ethrex --builder.gas-limit

Why

#1585 defaults HIVE_TARGET_GAS_LIMIT to 60,000,000 in rpc-compat so that testing_buildBlockV1 builds deterministic blocks across clients. A client that does not consume the variable keeps its own default and builds a different gas limit, which changes the block hash. Besu fails 2 of 4 buildBlockV1 tests on current execution-apis fixtures for this reason.

Verification

Ran rpc-compat/testing_buildBlockV1 with besu (main), erigon and reth (glamsterdam-devnet-8 images) before and after, on both the current fixtures and the ethereum/execution-apis#867 Amsterdam fixtures:

An alternative is to emit the value from hivechain's forkenv output. The sim-side default from #1585 already covers where the value comes from, so this PR only adds the client-side consumption.

@danceratopz danceratopz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MysticRyuujin, this LGTM.

Sorry for the commit noise here, I saw that nimbus-el wasn't added, before realizing that this flag was marked as deprecated and that nimbus doesn't support testing_buildBlockV1, so reverted that commit!

@danceratopz
danceratopz merged commit b9faf3d into ethereum:master Aug 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants