Skip to content

fix(test-forks,tests): fix latent base fee and blob transition bugs - #3721

Merged
marioevz merged 3 commits into
ethereum:forks/bogotafrom
spencer-tb:fix/latent-base-fee-blob-transition-bugs
Oct 7, 2026
Merged

marioevz merged 3 commits into
ethereum:forks/bogotafrom
spencer-tb:fix/latent-base-fee-blob-transition-bugs

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes three latent bugs that surface on the first Amsterdam-era transition with a blob schedule or base fee rule change (Amsterdam to Bogota with EIP-8198): base_fee_change_calculator misses reachable base fees (round-down short on increases, off by one gas on exact decreases), test_reserve_price_at_transition predicts the fork block's base fee with the parent fork's rule, and test_fork_transition_excess_blob_gas_post_blob_genesis gives the destination-creating blob transaction too little gas for Amsterdam's new-account state gas. All existing fixtures are unchanged.

Related Issues or PRs

Found on #3703.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.93%. Comparing base (f329cb4) to head (124a272).

Additional details and impacted files
@@              Coverage Diff              @@
##           forks/bogota    #3721   +/-   ##
=============================================
  Coverage         94.93%   94.93%           
=============================================
  Files               672      672           
  Lines             40846    40846           
  Branches           3775     3775           
=============================================
  Hits              38776    38776           
  Misses             1439     1439           
  Partials            631      631           
Flag Coverage Δ
unittests 94.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb spencer-tb added C-bug Category: this is a bug, deviation, or other problem A-test-forks Area: execution_testing.forks A-tests Area: Consensus tests. labels Oct 6, 2026
@spencer-tb
spencer-tb marked this pull request as ready for review October 6, 2026 12:53

@marioevz marioevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes. I took the opportunity to do some quality-of-life improvements to the tests touched, and also fixed the approach of adding the account creation state cost by using a pre-funded account instead.
I'll try to re-target the branch to forks/bogota and then merge.

@marioevz
marioevz changed the base branch from forks/amsterdam to forks/bogota October 7, 2026 17:11
@marioevz
marioevz force-pushed the fix/latent-base-fee-blob-transition-bugs branch from a83a6d0 to 124a272 Compare October 7, 2026 17:12
@marioevz
marioevz merged commit 4daa5df into ethereum:forks/bogota Oct 7, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-forks Area: execution_testing.forks A-tests Area: Consensus tests. C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants