Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/bogota #3721 +/- ##
=============================================
Coverage 94.93% 94.93%
=============================================
Files 672 672
Lines 40846 40846
Branches 3775 3775
=============================================
Hits 38776 38776
Misses 1439 1439
Partials 631 631
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
marked this pull request as ready for review
October 6, 2026 12:53
marioevz
approved these changes
Oct 7, 2026
marioevz
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the fixes. I took the opportunity to do some quality-of-life improvements to the tests touched, and also fixed the approach of adding the account creation state cost by using a pre-funded account instead.
I'll try to re-target the branch to forks/bogota and then merge.
marioevz
force-pushed
the
fix/latent-base-fee-blob-transition-bugs
branch
from
October 7, 2026 17:12
a83a6d0 to
124a272
Compare
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes three latent bugs that surface on the first Amsterdam-era transition with a blob schedule or base fee rule change (Amsterdam to Bogota with EIP-8198):
base_fee_change_calculatormisses reachable base fees (round-down short on increases, off by one gas on exact decreases),test_reserve_price_at_transitionpredicts the fork block's base fee with the parent fork's rule, andtest_fork_transition_excess_blob_gas_post_blob_genesisgives the destination-creating blob transaction too little gas for Amsterdam's new-account state gas. All existing fixtures are unchanged.Related Issues or PRs
Found on #3703.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.