chore(tests): replace stale TODO docstrings in revert_opcode_in_init - #3602
Closed
shubham5080 wants to merge 1 commit into
Closed
shubham5080 wants to merge 1 commit into
shubham5080 wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
Contributor
Author
|
Folded into #3606 per review feedback — closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the leftover machine-port
TODO revertOpcodeInInit followed by OOGplaceholders intest_revert_opcode_in_initwith docstrings that describe what the test actually verifies: REVERT in create-tx initcode discards the account (ops after REVERT never run) and the sender nonce advances.The EIP-8037 gas bump (
@manually-enhanced) was already done in #2901; Cancun/Amsterdam fill was already green. This is docstring-only cleanup.Verified:
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>Cute Animal Picture