Skip to content

chore(tests): replace stale TODO docstrings in revert_opcode_in_init - #3602

Closed
shubham5080 wants to merge 1 commit into
ethereum:forks/amsterdamfrom
shubham5080:chore/revert-opcode-in-init-docstring
Closed

shubham5080 wants to merge 1 commit into
ethereum:forks/amsterdamfrom
shubham5080:chore/revert-opcode-in-init-docstring

Conversation

@shubham5080

@shubham5080 shubham5080 commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Description

Replaces the leftover machine-port TODO revertOpcodeInInit followed by OOG placeholders in test_revert_opcode_in_init with docstrings that describe what the test actually verifies: REVERT in create-tx initcode discards the account (ops after REVERT never run) and the sender nonce advances.

The EIP-8037 gas bump (@manually-enhanced) was already done in #2901; Cancun/Amsterdam fill was already green. This is docstring-only cleanup.

Verified:

uv run fill tests/ported_static/stRevertTest/test_revert_opcode_in_init.py --fork=Cancun -q --clean
uv run fill tests/ported_static/stRevertTest/test_revert_opcode_in_init.py --fork=Amsterdam -q --clean
just static

Related Issues or PRs

N/A.

Checklist

  • Ran fast static checks: just static
  • PR title has the form <type>(<area>): <title>

Cute Animal Picture

otter

Co-authored-by: Cursor <cursoragent@cursor.com>
@shubham5080

Copy link
Copy Markdown
Contributor Author

Folded into #3606 per review feedback — closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant