Skip to content

chore(tests): drop stale EIP-8037 TODO on the 7702 precompile intrinsic gas test - #3581

Closed
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:chore/7702-precompile-gas-todo
Closed

spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:chore/7702-precompile-gas-todo

Conversation

@spencer-tb

Copy link
Copy Markdown
Contributor

Description

Delete the stale TODO: Add EIP-8037-specific variant in tests/amsterdam/ from test_set_code_to_precompile_not_enough_gas_for_precompile_execution and point the docstring at the tests that already cover the EIP-8037 side:

  • tests/amsterdam/eip2780_reduce_intrinsic_tx_gas/test_value_moving_with_tx_delegation.py: value transfer to an authority delegated in the same transaction, at an exact gas limit.
  • The existing-authority receipt and header tests in tests/amsterdam/eip8037_state_creation_gas_cost_increase/test_state_gas_set_code.py.

A precompile delegation target adds no new path on top of those because the precompile body never runs; the ungated Prague test_set_code_to_precompile already exercises that on Amsterdam. The valid_before("EIP8037") gate stays, since the Prague receipt expectation (auth refund discount) is not valid under the 2-D gas model.

Related Issues or PRs

Alternative to #3561, which added the variant as an 18-way precompile matrix.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

otter

@codecov

codecov Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.44%. Comparing base (9898add) to head (aeb7b2f).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3581   +/-   ##
================================================
  Coverage            94.44%   94.44%           
================================================
  Files                  624      624           
  Lines                36927    36927           
  Branches              3326     3326           
================================================
  Hits                 34874    34874           
  Misses                1450     1450           
  Partials               603      603           
Flag Coverage Δ
unittests 94.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb

Copy link
Copy Markdown
Contributor Author

Closing in favour of carrying this change on #3561 instead.

@spencer-tb spencer-tb closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant