chore(tests): drop stale EIP-8037 TODO on the 7702 precompile intrinsic gas test - #3581
Closed
spencer-tb wants to merge 1 commit into
Closed
spencer-tb wants to merge 1 commit into
spencer-tb wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3581 +/- ##
================================================
Coverage 94.44% 94.44%
================================================
Files 624 624
Lines 36927 36927
Branches 3326 3326
================================================
Hits 34874 34874
Misses 1450 1450
Partials 603 603
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing in favour of carrying this change on #3561 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delete the stale
TODO: Add EIP-8037-specific variant in tests/amsterdam/fromtest_set_code_to_precompile_not_enough_gas_for_precompile_executionand point the docstring at the tests that already cover the EIP-8037 side:tests/amsterdam/eip2780_reduce_intrinsic_tx_gas/test_value_moving_with_tx_delegation.py: value transfer to an authority delegated in the same transaction, at an exact gas limit.tests/amsterdam/eip8037_state_creation_gas_cost_increase/test_state_gas_set_code.py.A precompile delegation target adds no new path on top of those because the precompile body never runs; the ungated Prague
test_set_code_to_precompilealready exercises that on Amsterdam. Thevalid_before("EIP8037")gate stays, since the Prague receipt expectation (auth refund discount) is not valid under the 2-D gas model.Related Issues or PRs
Alternative to #3561, which added the variant as an 18-way precompile matrix.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture