chore(tests): drop stale EIP-8037 fork split in BAL insufficient-funds test - #3545
Merged
fselmo merged 2 commits intoSep 8, 2026
Merged
Conversation
…s test This file is valid_from Amsterdam where EIP-8037 is always enabled, so the pre-8037 branch and ethereum#2473 TODO were unreachable dead code. Co-authored-by: Cursor <cursoragent@cursor.com>
fselmo
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the dead
fork.is_eip_enabled(8037)branch intest_bal_call_revert_insufficient_funds.This file is
valid_from("Amsterdam"), and Amsterdam always enables EIP-8037, so the pre-8037elsepath was unreachable. The accompanying TODO waited on #2473 being consolidated into Amsterdam; that PR already merged, and EIP-8037 (#2901) kept the early code-read behavior that this test asserts.Also drops the unused
forkfixture argument from the test and updates the docstring/comment to match current Amsterdam behavior.Filled locally:
24 passed.
Related Issues or PRs
Follow-up cleanup after #2473 and #2901.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture