feat(tests): complete EIP-7981 coverage and testing checklist by danceratopz · Pull Request #3537 · ethereum/execution-specs

danceratopz · 2026-09-07T07:24:46Z

Description

Strengthen EIP-7981 tests to check successful execution and exact gas charges.

Every transaction built by the shared fixtures now carries an expected receipt with success status and the exact gas used, and a gas limit that also funds the top-frame authorization gas of type 4 transactions. A default surplus of 1000 gas shows that unused gas is returned; the exact gas limit test sets the surplus to zero.
Add 4 tests covering the billing crossover, recipient and value interactions, the execution out-of-gas boundary, and refund and revert interactions.
Cover both outcomes at the calldata floor boundary with exact upfront funding, cover duplicate storage keys within one entry, and record the floor exception when the floor check is what rejects a transaction.
Realign checklist markers on 5 tests and document the coverage and N/A decisions in the checklist files.
Correct the EIP reference pin to the blob hash of the revision that was already pinned by commit hash; the pinned content is unchanged.

Nimbus rejects a block that has transactions and a header gasUsed of zero before it validates any transaction, so it reports the intrinsic gas exception for the below-floor cases of the floor validation and exact-balance tests. Those cases pass on Nimbus once invalid-transaction blocks carry a nonzero header gasUsed, which is the subject of the follow-up #3599. This is kinda low prio. Currently exception mapping is disabled for nimbus (in the hive sim Dockerfiles), see #3603.

Validation at the current head: just static passes, and all 731 EIP-7981 fill cases pass with --until Amsterdam --generate-all-formats, including 184 EngineX fixtures and the activation transitions. The regenerated checklist covers all 15 applicable items with 254 items marked N/A and no unmarked tests. consume enginex against go-ethereum, Nethermind, ethrex, Erigon, Besu and Reth passes all 186 cases each; Nimbus passes 174 and fails the 12 below-floor cases named above until the follow-up lands. Devnet execution and consume engine remain open.

Related Issues or PRs

Checklist

Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

codecov · 2026-09-07T07:28:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.47%. Comparing base (52161d9) to head (0523b49).
⚠️ Report is 13 commits behind head on forks/amsterdam.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           forks/amsterdam    #3537      +/-   ##
===================================================
+ Coverage            94.44%   94.47%   +0.03%     
===================================================
  Files                  624      624              
  Lines                36928    36969      +41     
  Branches              3326     3334       +8     
===================================================
+ Hits                 34875    34925      +50     
+ Misses                1450     1443       -7     
+ Partials               603      601       -2

Flag	Coverage Δ
unittests	`94.47% <ø> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Expand test_access_list_data_cost_with_execution with calldata-floor and execution-cost dominance for zero and nonzero calldata, retaining transaction types 1 and 2. These cases catch a surcharge omitted from either side of the gas-used maximum. Derive the surcharge independently of the access-list calculator and provide surplus gas so an out-of-gas transaction cannot satisfy the receipt assertion simply by consuming the entire gas limit. Validation: all 24 focused EELS fill cases and just static pass against the unrefactored specification on forks/amsterdam.

Add test_execution_gas_after_access_list_surcharge. The existing OOG checklist markers only cover transactions rejected before execution for insufficient intrinsic or floor gas. They do not prove that EIP-7981's surcharge is deducted before the EVM runs. Add an exact execution-gas boundary around a warm SSTORE for transaction types 1 and 2. Assert receipt status, gas used and storage rollback with one gas too little, exact gas and one extra gas. This supplies actual execution-OOG evidence for the gas-cost checklist item. Validation: focused EELS fill and just static pass before this commit.

Build the transaction gas limit from the gas the transaction is expected to use, including the top-frame authorization gas of type 4 transactions, and attach an expected receipt with success status and that exact gas to every valid fixture-built transaction. Until now the fixture limit stopped at the intrinsic cost, so type 4 transactions ran out of gas while processing their authorization, and the gas-measurement tests only checked acceptance. Add a gas surplus fixture, on by default, so a receipt that equals the gas limit cannot pass by consuming everything. The exact gas limit test sets it to zero. Annotate the authorization fixtures with whether they create an account so the top-frame gas is modeled. Remove the manual receipt in the calldata floor test, which the fixture now supersedes.

The shared error fixture returned the intrinsic gas exception for every negative gas delta. When the calldata floor exceeds the intrinsic cost, the gas limit sits between the two and the specification rejects on the floor check, so record that exception. This changes the floor validation test; the intrinsic gas cases keep their exception. Nimbus reports the intrinsic exception for these blocks because it rejects a block with transactions and zero gas used before validating any transaction. That needs invalid-transaction blocks to carry a nonzero header gas used, which is a separate change.

Add test_access_list_floor_with_exact_balance. The existing exact-balance scenario only rejected a gas limit midway through the surcharge gap. The data-floor checklist requires both valid and invalid transactions when the floor exceeds intrinsic gas. Use floor minus one, exact floor and floor plus one limits. Assert receipt status, gas used and the sender's final balance for valid cases, with full upfront funding for both transaction types 1 and 2. Correct the marker from execution OOG to data-floor intrinsic validity. Validation: focused EELS fill and just static pass before this commit.

Map gas-limit and data-floor rejection to intrinsic validity rather than execution OOG. Credit exact valid limits and contract creation with their specific checklist items; preserve actual gas measurements. Validation: module EELS fill and just static pass before this commit.

Both gas-transition tests already assert fork-specific billed gas through receipts or sender balances. Add the gas-measurement mapping alongside their existing before/after activation decorators. The validity-transition test already covers all four required outcomes. Validation: module EELS fill and just static pass before this commit.

Strengthen test_duplicate_access_list_entries. The existing duplicate-address-entry case does not detect a client that deduplicates storage keys within each entry. Add that distinct shape to the measured duplicate test without multiplying unrelated parameters. This is an optional improvement beyond checklist closure. Validation: focused EELS fill and just static pass before this commit.

Add test_access_list_data_cost_at_crossover. The existing surcharge regression tests well-separated floor and execution dominance. Add the exact crossover and adjacent execution gas values for zero and nonzero calldata, retaining the existing cases. Use surplus gas and exact receipts to detect a misplaced max operation. This is an independent improvement beyond checklist closure. Validation: focused EELS fill and just static pass before this commit.

Add test_access_list_surcharge_with_refund. EIP-7981 preserves refund rules, so the new-refund checklist section is not applicable. Add independent interaction coverage: clear a warm slot, optionally revert, and assert storage, receipt status and gas after refunds with and without calldata-floor dominance. This checks that the surcharged floor still binds and revert discards the refund. Validation: focused EELS fill and just static pass before this commit.

Add test_access_list_surcharge_with_recipient_costs. The surcharge must survive Amsterdam's different intrinsic bases for self-transfers and value-bearing transfers. The previous cases only used non-self recipients with zero value. Add focused combinations of self/other recipients and zero/nonzero value with and without floor dominance. Derive the expected surcharge separately from calculators without an access list, and assert success and billed gas with surplus gas. Use an existing funded recipient so account creation cannot obscure the repricing being measured. This is an optional interaction regression beyond checklist closure. Validation: focused EELS fill and just static pass before this commit.

Replace the blanket transaction-type exclusion with exclusions for the rules EIP-7981 leaves unchanged, keeping the exact and insufficient gas limit, floor validity and contract creation items for the repriced transaction types. Record the coverage evidence as self-contained statements and mark the optional second-client instrumentation as not collected rather than as validation.

Since ethereum#3223 the pin has been the hash of the EIPs commit that moved the EIP to Review, so the version check never matched a blob. Use the blob hash of eip-7981.md in that same commit. The pinned content is unchanged. Relative to the blob pinned before ethereum#3223 (954963f), the only difference is the status change from Draft to Review.

LouisTsai-Csie

Thanks for the checklist PR. A few ideas:

Two-dimensional gas: execution cost with access list dominates header cost.
Combine test_access_list_data_cost_with_execution and test_access_list_data_cost_at_crossover as they have similar structure.

spencer-tb · 2026-09-17T15:11:34Z

Follow up review PR: danceratopz#61

Fire away! :)

… cost tests

…xed floor case

LouisTsai-Csie

LGTM from my side

danceratopz added C-feat Category: an improvement or new feature A-test-cli Area: execution_testing.cli A-tests Area: Consensus tests. labels Sep 7, 2026

danceratopz mentioned this pull request Sep 7, 2026

refactor(spec-specs): clarify the EIP-7981 data surcharge #3536

Merged

2 tasks done

spencer-tb added this to the tests@v21.0.0 (Glamsterdam Testnet) milestone Sep 14, 2026

danceratopz force-pushed the 7981-improve-tests branch from fb73a23 to 906c947 Compare September 15, 2026 06:10

danceratopz removed the A-test-cli Area: execution_testing.cli label Sep 15, 2026

danceratopz mentioned this pull request Sep 15, 2026

fix(test-cli): render coverage on repeated checklist rows #3586

Merged

2 tasks done

danceratopz force-pushed the 7981-improve-tests branch 2 times, most recently from b9126b3 to 4b26471 Compare September 15, 2026 11:57

danceratopz marked this pull request as ready for review September 15, 2026 12:31

danceratopz marked this pull request as draft September 15, 2026 12:55

danceratopz force-pushed the 7981-improve-tests branch from a214f03 to 5cb8faa Compare September 15, 2026 12:57

danceratopz added 13 commits September 15, 2026 17:45

danceratopz force-pushed the 7981-improve-tests branch from 5cb8faa to e0e8200 Compare September 16, 2026 08:42

danceratopz marked this pull request as ready for review September 16, 2026 11:14

danceratopz requested a review from spencer-tb September 16, 2026 11:21

This was referenced Sep 16, 2026

Test Release Tracker: tests@v21.0.0 (Glamsterdam Testnet) #3217

Open

fix(test-specs): give invalid-transaction blocks a nonzero header gas used #3599

Closed

LouisTsai-Csie requested changes Sep 17, 2026

View reviewed changes

This was referenced Sep 17, 2026

feat(tests): strengthen EIP-7981 gas and balance coverage danceratopz/execution-specs#61

Merged

feat(tests): add execution-dominant EIP-7981 block gas coverage danceratopz/execution-specs#62

Closed

spencer-tb and others added 8 commits September 18, 2026 10:34

refactor(tests): trim the EIP-7981 shared fixtures

ab8febb

feat(tests): bind the floor and merge the crossover cases in EIP-7981…

a75178e

… cost tests

feat(tests): cover EIP-7981 sender balance boundaries and bind the mi…

8d48c3b

…xed floor case

feat(tests): pin the EIP-7981 surcharge in the block execution dimension

c7c6eb0

docs(tests): record the added EIP-7981 checklist coverage

c709ed2

test(amsterdam): cover execution-dominant EIP-7981 block gas

0b62104

docs(tests): clarify state gas billing in EIP-7981 tests

574d9e1

docs(tests): qualify EIP-7981 test coverage claim

0523b49

danceratopz requested a review from LouisTsai-Csie September 18, 2026 08:35

LouisTsai-Csie approved these changes Sep 21, 2026

View reviewed changes

danceratopz merged commit 127be12 into ethereum:forks/amsterdam Sep 21, 2026
20 checks passed

danceratopz deleted the 7981-improve-tests branch September 21, 2026 06:17

Navigation Menu

Repository navigation

feat(tests): complete EIP-7981 coverage and testing checklist - #3537

feat(tests): complete EIP-7981 coverage and testing checklist#3537
danceratopz merged 21 commits into
ethereum:forks/amsterdamfrom
danceratopz:7981-improve-tests

danceratopz commented Sep 7, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Sep 7, 2026 •

edited

Loading

Uh oh!

LouisTsai-Csie left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spencer-tb commented Sep 17, 2026

Uh oh!

LouisTsai-Csie left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

danceratopz commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues or PRs

Checklist

Cute Animal Picture

Uh oh!

codecov Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LouisTsai-Csie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spencer-tb commented Sep 17, 2026

Uh oh!

LouisTsai-Csie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danceratopz commented Sep 7, 2026 •

edited

Loading

codecov Bot commented Sep 7, 2026 •

edited

Loading