fix(test-execute): ignore tests/spec_tools during collection - #3450
Merged
spencer-tb merged 1 commit intoAug 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3450 +/- ##
================================================
Coverage 93.77% 93.77%
================================================
Files 624 624
Lines 36905 36905
Branches 3326 3326
================================================
Hits 34606 34606
Misses 1597 1597
Partials 702 702
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 tasks done
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #3307 moved
tests/evm_tools/test_*.pytotests/spec_tools/, but the fill and execute pytest configs still ignored the old path.executecollects these plain unit tests, gives them aforkparameter via the autouseprefixture, and then crashes during collection because they have no spec type format:This is what stopped the eels/execute simulator runs on the glamsterdam Hive dashboard. Update the stale
--ignore tests/evm_toolsentries to--ignore tests/spec_tools.Note: this also needs to reach
devnets/glamsterdam/8for the dashboard to recover.Related Issues or PRs
Fixes #3438:
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture