Skip to content

fix(test-execute): ignore tests/spec_tools during collection - #3450

Merged
spencer-tb merged 1 commit into
ethereum:forks/amsterdamfrom
danceratopz:hive-glammy-execute
Aug 26, 2026
Merged

spencer-tb merged 1 commit into
ethereum:forks/amsterdamfrom
danceratopz:hive-glammy-execute

Conversation

@danceratopz

@danceratopz danceratopz commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

Description

PR #3307 moved tests/evm_tools/test_*.py to tests/spec_tools/, but the fill and execute pytest configs still ignored the old path. execute collects these plain unit tests, gives them a fork parameter via the autouse pre fixture, and then crashes during collection because they have no spec type format:

INTERNALERROR> ValueError: No spec type format found in the test item.

This is what stopped the eels/execute simulator runs on the glamsterdam Hive dashboard. Update the stale --ignore tests/evm_tools entries to --ignore tests/spec_tools.

Note: this also needs to reach devnets/glamsterdam/8 for the dashboard to recover.

Related Issues or PRs

Fixes #3438:

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

 (\ /)
 ( .c.)
 o(")(")

@danceratopz danceratopz added the A-test-execute Area: execution_testing.cli.pytest_commands.plugins.execute label Aug 26, 2026
@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.77%. Comparing base (2ce2191) to head (4062af9).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #3450   +/-   ##
================================================
  Coverage            93.77%   93.77%           
================================================
  Files                  624      624           
  Lines                36905    36905           
  Branches              3326     3326           
================================================
  Hits                 34606    34606           
  Misses                1597     1597           
  Partials               702      702           
Flag Coverage Δ
unittests 93.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danceratopz danceratopz added the C-bug Category: this is a bug, deviation, or other problem label Aug 26, 2026

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@spencer-tb
spencer-tb merged commit 74153f7 into ethereum:forks/amsterdam Aug 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-execute Area: execution_testing.cli.pytest_commands.plugins.execute C-bug Category: this is a bug, deviation, or other problem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eels/execute, hive mode internal error

2 participants