test(spec-specs): add unit tests for get_last_256_block_hashes - #3397
Merged
spencer-tb merged 3 commits intoAug 24, 2026
Merged
spencer-tb merged 3 commits into
spencer-tb merged 3 commits into
Conversation
Pin empty, short, 256-window, and overflow chains on the Frontier helper, which EEST BLOCKHASH tests do not call.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3397 +/- ##
================================================
Coverage 93.53% 93.54%
================================================
Files 624 624
Lines 37070 37074 +4
Branches 3394 3394
================================================
+ Hits 34675 34681 +6
+ Misses 1645 1644 -1
+ Partials 750 749 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
added
C-test
spencer-tb
changed the title
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds direct unit tests for Frontier
get_last_256_block_hashes(empty / 1 / <256 / 255 / 256 / 257 blocks, hash order, most-recent keccak). EEST BLOCKHASH tests go through t8n and do not exercise this helper. Asked in#el-testingbefore starting.TODO removed only on Frontier for now; other forks still have the copy.
Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>Cute Animal Picture