Skip to content

refactor(test-specs,tests): Refactor inclusion-list spec definitions, existing tests - #3373

Merged
marioevz merged 5 commits into
ethereum:eips/bogota/eip-7805from
marioevz:eips/bogota/eip-7805
Aug 19, 2026
Merged

marioevz merged 5 commits into
ethereum:eips/bogota/eip-7805from
marioevz:eips/bogota/eip-7805

Conversation

@marioevz

Copy link
Copy Markdown
Member

Description

Test Spec Updates

  • Adds Block.expected_inclusion_list_satisfied, asserted against the transition tool's inclusion_list_satisfied result while filling. Tests can now state the expected FOCIL outcome directly to verify the test's correctness, and normal tests can simply use the returned value from the t8n.
  • Fixes a gas-limit budget miscount: a transaction present in both txs and inclusion_list_txs executes once, so it must be counted once against the gas-limit calculation. It is now deduplicated by identity, which previously either double-subtracted an explicit gas limit or inflated the divisor used for unset limits.
  • The transition tool no longer treats a missing inclusion list as satisfied; it raises, so a future plumbing gap fails loudly instead of asserting a vacuously satisfied block.

Tests

  • Deletes helpers.py (288 lines): build_block, its spec tuples, the calldata-for-target-gas solver.
  • Splits test_focil.py into four files by concern: inclusion-list transactions included in the block body (test_focil.py), appendability by transaction validity (test_pending_il_validity.py), appendability by remaining execution gas (test_block_gas_limit.py), and per-type decodability (test_tx_types.py).
  • Coverage increased by extra parametrization of existing tests.

TODOs

Related Issues or PRs

N/A.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/bogota/eip-7805@ae3d89f). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             eips/bogota/eip-7805    #3373   +/-   ##
=======================================================
  Coverage                        ?   93.50%           
=======================================================
  Files                           ?      624           
  Lines                           ?    37095           
  Branches                        ?     3397           
=======================================================
  Hits                            ?    34684           
  Misses                          ?     1660           
  Partials                        ?      751           
Flag Coverage Δ
unittests 93.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me! Only small nits! Nice refactor :)

Comment thread tests/bogota/eip7805_focil/test_focil.py Outdated
Comment thread tests/bogota/eip7805_focil/test_block_gas_limit.py
Comment thread tests/bogota/eip7805_focil/test_focil.py Outdated
Comment thread tests/bogota/eip7805_focil/test_focil.py Outdated
Comment thread tests/bogota/eip7805_focil/test_focil.py Outdated
Co-authored-by: spencer <spencer.tb@ethereum.org>
Co-authored-by: Mario Vega <marioevz@gmail.com>
@marioevz
marioevz merged commit aa25eed into ethereum:eips/bogota/eip-7805 Aug 19, 2026
31 checks passed
fselmo pushed a commit that referenced this pull request Sep 15, 2026
… existing tests (#3373)

* feat(test-specs): Add inclusion list satisfied verification to block

* fix(test-specs): fix framework on missing inclusion list

* refactor(tests): refactor existing focil tests

* nit(test-specs): Unnecessary comment

* Apply suggestions from code review

Co-authored-by: spencer <spencer.tb@ethereum.org>
Co-authored-by: Mario Vega <marioevz@gmail.com>

---------

Co-authored-by: spencer <spencer.tb@ethereum.org>
fselmo pushed a commit that referenced this pull request Sep 23, 2026
… existing tests (#3373)

* feat(test-specs): Add inclusion list satisfied verification to block

* fix(test-specs): fix framework on missing inclusion list

* refactor(tests): refactor existing focil tests

* nit(test-specs): Unnecessary comment

* Apply suggestions from code review

Co-authored-by: spencer <spencer.tb@ethereum.org>
Co-authored-by: Mario Vega <marioevz@gmail.com>

---------

Co-authored-by: spencer <spencer.tb@ethereum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants