refactor(test-specs,tests): Refactor inclusion-list spec definitions, existing tests - #3373
Merged
marioevz merged 5 commits intoAug 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/bogota/eip-7805 #3373 +/- ##
=======================================================
Coverage ? 93.50%
=======================================================
Files ? 624
Lines ? 37095
Branches ? 3397
=======================================================
Hits ? 34684
Misses ? 1660
Partials ? 751
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
self-requested a review
August 18, 2026 13:50
marioevz
marked this pull request as ready for review
August 18, 2026 13:52
spencer-tb
approved these changes
Aug 19, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
All looks good to me! Only small nits! Nice refactor :)
marioevz
commented
Aug 19, 2026
marioevz
commented
Aug 19, 2026
Co-authored-by: spencer <spencer.tb@ethereum.org> Co-authored-by: Mario Vega <marioevz@gmail.com>
2 tasks
fselmo
pushed a commit
that referenced
this pull request
Sep 15, 2026
… existing tests (#3373) * feat(test-specs): Add inclusion list satisfied verification to block * fix(test-specs): fix framework on missing inclusion list * refactor(tests): refactor existing focil tests * nit(test-specs): Unnecessary comment * Apply suggestions from code review Co-authored-by: spencer <spencer.tb@ethereum.org> Co-authored-by: Mario Vega <marioevz@gmail.com> --------- Co-authored-by: spencer <spencer.tb@ethereum.org>
fselmo
pushed a commit
that referenced
this pull request
Sep 23, 2026
… existing tests (#3373) * feat(test-specs): Add inclusion list satisfied verification to block * fix(test-specs): fix framework on missing inclusion list * refactor(tests): refactor existing focil tests * nit(test-specs): Unnecessary comment * Apply suggestions from code review Co-authored-by: spencer <spencer.tb@ethereum.org> Co-authored-by: Mario Vega <marioevz@gmail.com> --------- Co-authored-by: spencer <spencer.tb@ethereum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Spec Updates
Block.expected_inclusion_list_satisfied, asserted against the transition tool'sinclusion_list_satisfiedresult while filling. Tests can now state the expected FOCIL outcome directly to verify the test's correctness, and normal tests can simply use the returned value from the t8n.txsandinclusion_list_txsexecutes once, so it must be counted once against the gas-limit calculation. It is now deduplicated by identity, which previously either double-subtracted an explicit gas limit or inflated the divisor used for unset limits.Tests
helpers.py(288 lines):build_block, its spec tuples, the calldata-for-target-gas solver.test_focil.pyinto four files by concern: inclusion-list transactions included in the block body (test_focil.py), appendability by transaction validity (test_pending_il_validity.py), appendability by remaining execution gas (test_block_gas_limit.py), and per-type decodability (test_tx_types.py).TODOs
inclusion_testmarked tests from feat(test-specs): Allow specs to fill same fixture format more than once, addinclusion_testmarker #3337Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture