feat(tests): extend block-gas inclusion boundary test to Osaka - #3076
Merged
spencer-tb merged 2 commits intoJul 1, 2026
Merged
spencer-tb merged 2 commits into
spencer-tb merged 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3076 +/- ##
===================================================
- Coverage 93.22% 93.22% -0.01%
===================================================
Files 624 624
Lines 36926 36939 +13
Branches 3377 3377
===================================================
+ Hits 34424 34436 +12
- Misses 1708 1709 +1
Partials 794 794
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The regular-gas cumulative inclusion gate probed by test_tx_inclusion_at_regular_gas_block_limit_small (reject a tx whose gas_limit exceeds block.gas_limit minus the cumulative gas used, strict >) is the pre-existing block-gas rule, not an EIP-8037 novelty, and its construction (filler txs plus a bare-STOP excess tx) is fork-agnostic. Lower its valid_from from EIP8037 to Osaka to add the missing pre-Amsterdam fixtures. The sibling test_tx_gas_larger_than_block_gas_limit does not cover this boundary: its Op.INVALID txs consume their full gas, so the block's final gas_used <= limit check, not the inclusion gate, decides validity. Also pin the accepted case with header_verify(gas_used=block_gas_limit), so the positive branch checks the produced block gas rather than only that the block is valid. Verified filling at Osaka (block_gas_limit=42_000; exceeds rejected with GAS_ALLOWANCE_EXCEEDED) and Amsterdam (block_gas_limit=63_000).
chfast
force-pushed
the
tests/osaka/cumulative-block-gas-rejection
branch
from
July 1, 2026 09:09
f583d02 to
4873cf1
Compare
LouisTsai-Csie
approved these changes
Jul 1, 2026
…block_2d_gas_accounting.py
spencer-tb
approved these changes
Jul 1, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks. I added a comment above the fork from range :)
Member
Author
Thanks. |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
The regular-gas cumulative inclusion gate probed by
test_tx_inclusion_at_regular_gas_block_limit_small (reject a tx whose
gas_limit exceeds block.gas_limit minus the cumulative gas used, strict
The sibling test_tx_gas_larger_than_block_gas_limit does not cover this
boundary: its Op.INVALID txs consume their full gas, so the block's
final gas_used <= limit check, not the inclusion gate, decides validity.
Also pin the accepted case with header_verify(gas_used=block_gas_limit),
so the positive branch checks the produced block gas rather than only
that the block is valid.
Verified filling at Osaka (block_gas_limit=42_000; exceeds rejected with
GAS_ALLOWANCE_EXCEEDED) and Amsterdam (block_gas_limit=63_000).
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture