chore(tests): fix failing ported static slow tests for EIP-8038 - #3019
Merged
spencer-tb merged 1 commit intoJun 18, 2026
Merged
spencer-tb merged 1 commit into
spencer-tb merged 1 commit into
Conversation
spencer-tb
changed the title
spencer-tb
marked this pull request as ready for review
June 18, 2026 22:41
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-2780-8038 #3019 +/- ##
===============================================================
Coverage ? 93.21%
===============================================================
Files ? 620
Lines ? 38831
Branches ? 3348
===============================================================
Hits ? 36198
Misses ? 1773
Partials ? 860
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
merged commit Jun 18, 2026
82bd503
into
ethereum:eips/amsterdam/eip-2780-8038
17 checks passed
spencer-tb
added a commit
that referenced
this pull request
Jun 18, 2026
Co-authored-by: marioevz <marioevz@gmail.com>
spencer-tb
added a commit
that referenced
this pull request
Jun 18, 2026
Co-authored-by: marioevz <marioevz@gmail.com>
spencer-tb
added a commit
that referenced
this pull request
Jun 19, 2026
Co-authored-by: marioevz <marioevz@gmail.com>
danceratopz
pushed a commit
that referenced
this pull request
Jul 2, 2026
Co-authored-by: marioevz <marioevz@gmail.com>
danceratopz
pushed a commit
that referenced
this pull request
Jul 2, 2026
Co-authored-by: marioevz <marioevz@gmail.com>
spencer-tb
added a commit
that referenced
this pull request
Jul 2, 2026
Co-authored-by: marioevz <marioevz@gmail.com>
marioevz
added a commit
that referenced
this pull request
Jul 2, 2026
* feat(spec-specs, tests): add EIP-8038 state-access gas cost update (#2972) Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Mario Vega <11726710+marioevz@users.noreply.github.com> * feat(spec-specs, tests): Implement EIP-2780 (#3017) * chore(tests): fix failing ported static slow tests for EIP-8038 (#3019) Co-authored-by: marioevz <marioevz@gmail.com> * test(amsterdam): add EIP-8038 state-access gas cost tests (#3033) Co-authored-by: danceratopz <danceratopz@gmail.com> Co-authored-by: marioevz <marioevz@gmail.com> * fix(tests): account for EIP-8246 in EIP-8038 selfdestruct gas test (#3044) EIP-8246 removes the `SELFDESTRUCT` balance burn, which changes the same-transaction self-destruct-to-self outcome. Gate the affected expectations in `test_selfdestruct_gas.py` on `fork.is_eip_enabled(8246)` so the test holds on forks with and without EIP-8246: - Pre-EIP-8246: The originator balance is burnt (a `Burn` log) and the same-transaction-created account is deleted. - EIP-8246 onwards: The burn is removed, so the self-send is a no-op; the balance stays in the (emptied) originator and no log is emitted. `burn_log` is imported lazily in the pre-EIP-8246 branch because EIP-8246 deletes the helper from the EIP-7708 spec. The charged gas is unchanged, so `cumulative_gas_used` is asserted identically on both sides. * fix(spec-specs): EIP-2780 charge `NEW_ACCOUNT` for value transfer to zero balance precompile (#3048) * fix(amsterdam): charge NEW_ACCOUNT for value transfer to empty precompile EIP-2780 charges the NEW_ACCOUNT state cost when a transaction transfers value to a recipient that is empty per EIP-161. The top-frame charge previously carved out precompile recipients, but neither EIP-2780 nor EIP-161 authorizes that exemption: - EIP-2780 does not mention precompiles; its rule keys solely on "empty per EIP-161 and tx.value > 0". - EIP-161 defines empty structurally (no code, zero nonce, zero balance) with no precompile exception, so an unfunded precompile is empty and is created by the value transfer like any other account. Remove the `recipient_is_precompile` carve-out from the top-frame charge so an empty precompile receiving value pays NEW_ACCOUNT, drop the matching special-case from the testing framework's `transaction_top_frame_state_gas`, and rewrite `test_value_move_to_precompiles` to assert the charge fires for the not-funded precompile while a pre-funded (alive) precompile remains exempt by virtue of being non-empty. Co-authored-by: danceratopz <danceratopz@gmail.com> * feat(tests): add more EIP-2780 tests (#3055) Co-authored-by: danceratopz <danceratopz@gmail.com> Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> * feat(specs): update EIP-8037 impl for ethereum/EIPs#11715 (#3021) Co-authored-by: spencer-tb <spencer.tb@ethereum.org> * fix(tests): align Amsterdam (gas) tests with EIP-2780/8037/8038 (#3088) Co-authored-by: marioevz <marioevz@gmail.com> * Apply suggestions from code review (packates/testing) Co-authored-by: Mario Vega <marioevz@gmail.com> * Apply suggestions from code review (specs) Co-authored-by: Mario Vega <marioevz@gmail.com> * Apply suggestions from code review (tests) Co-authored-by: Mario Vega <marioevz@gmail.com> * fix(specs): Lint * fix(test-tools): Lint --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Mario Vega <11726710+marioevz@users.noreply.github.com> Co-authored-by: Guruprasad Kamath <guru241987@gmail.com> Co-authored-by: spencer <spencer.taylor-brown@ethereum.org> Co-authored-by: marioevz <marioevz@gmail.com> Co-authored-by: CPerezz <37264926+CPerezz@users.noreply.github.com> Co-authored-by: Guruprasad Kamath <48196632+gurukamath@users.noreply.github.com> Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This is an exact copy of @marioevz's PR: danceratopz#58, to fix the slow ported static tests for EIP-8038.
🔗 Related Issues or PRs
N/A
✅ Checklist
just statictype(scope):.Cute Animal Picture