feat(tests): EIP-7928 cover many storage changes for one account - #2985
Merged
spencer-tb merged 1 commit intoJun 15, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2985 +/- ##
================================================
Coverage 90.53% 90.53%
================================================
Files 535 535
Lines 32895 32895
Branches 3022 3022
================================================
Hits 29782 29782
Misses 2595 2595
Partials 518 518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
Add `test_bal_many_storage_writes_single_account`, parametrized over 17, 32, and 128 distinct storage slots written by a single transaction to one contract. Existing EIP-7928 BAL storage tests touch at most a handful of slots per account (`test_bal_cross_tx_storage_chain` writes 8, one slot per transaction). This adds coverage for a much higher per-account, per-transaction storage-change cardinality, where the block access list must record every slot in ascending order at a single block access index. It stresses any client that records or preloads an account's BAL storage keys into a fixed-size buffer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
pirapira
force-pushed
the
test/bal-many-storage-writes-single-account
branch
from
June 13, 2026 14:01
b5c2753 to
114755b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
pirapira
marked this pull request as ready for review
June 14, 2026 15:01
pirapira
marked this pull request as draft
June 14, 2026 15:02
pirapira
marked this pull request as ready for review
June 14, 2026 15:08
spencer-tb
approved these changes
Jun 15, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the tests! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add
test_bal_many_storage_writes_single_accountto the EIP-7928 block-access-list suite, parametrized over 17, 32, and 128 distinct storage slots written by a single transaction to one contract.Existing BAL storage tests touch at most a handful of slots per account —
test_bal_cross_tx_storage_chainwrites eight, one slot per transaction. This adds coverage for a much higher per-account, per-transaction storage-change cardinality: the block access list must record every slot, in ascending order, at a single block access index. It stresses any client that records or preloads an account's BAL storage keys into a fixed-size buffer.This scenario was not covered by the existing suite and surfaced a fixed-size-buffer overflow in a stateless client implementation, so a post-mortem entry is also added in
docs/writing_tests/post_mortems.md.Filled clean for Amsterdam (blockchain + engine fixture formats); the produced BAL contains 17 / 32 / 128 storage changes for the recipient as expected.
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.Cute Animal Picture
"Brown Bear Sitting" by Accretion Disc is licensed under CC BY 2.0. To view a copy of this license, visit https://creativecommons.org/licenses/by/2.0/?ref=openverse.