Skip to content

chore(test-client-clis): update NethermindExceptionMapper strings for type-4 transactions - #2867

Merged
LouisTsai-Csie merged 1 commit into
ethereum:forks/amsterdamfrom
DarkLord017:type4_error_change
May 18, 2026
Merged

LouisTsai-Csie merged 1 commit into
ethereum:forks/amsterdamfrom
DarkLord017:type4_error_change

Conversation

@DarkLord017

@DarkLord017 DarkLord017 commented May 17, 2026

Copy link
Copy Markdown
Contributor

🗒️ Description

As in nethermind we changed to return a different error message for type4 txn error to change NethermindExceptionMapper

🔗 Related Issues or PRs

NethermindEth/nethermind#11606

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.14%. Comparing base (892e6d1) to head (6aaebba).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2867   +/-   ##
================================================
  Coverage            87.14%   87.14%           
================================================
  Files                  586      586           
  Lines                35792    35792           
  Branches              3364     3364           
================================================
  Hits                 31192    31192           
  Misses                3950     3950           
  Partials               650      650           
Flag Coverage Δ
unittests 87.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danceratopz danceratopz added A-test-client-clis Area: execution_testing.client_clis C-chore Category: chore labels May 18, 2026
@danceratopz danceratopz changed the title fix(tests): update NethermindExceptionMapper strings for type-4 transactions chore(test-client-clis): update NethermindExceptionMapper strings for type-4 transactions May 18, 2026
@LouisTsai-Csie
LouisTsai-Csie merged commit c6b7f17 into ethereum:forks/amsterdam May 18, 2026
24 checks passed
LouisTsai-Csie pushed a commit that referenced this pull request May 18, 2026
@DarkLord017
DarkLord017 deleted the type4_error_change branch May 18, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-client-clis Area: execution_testing.client_clis C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants