chore(tests): EIP-7825 test fix to avoid 3 failures on EIP-7976 ci run - #2286
Conversation
spencer-tb
left a comment
There was a problem hiding this comment.
test_tx_gas_limit_cap_contract_creation uses the same gas_available // total_cost_floor_per_token pattern, not failing now but might break if gas repricing hits that path. Worth converting to max_count_with_intrinsic_cost_at_most in a follow-up.
|
Created an issue with other tests that have similar ways of calcuting (nothing failing). It would be nice to update them in the future though. #2289 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2286 +/- ##
================================================
Coverage 85.86% 85.86%
================================================
Files 599 599
Lines 39390 39390
Branches 3770 3770
================================================
Hits 33822 33822
Misses 4938 4938
Partials 630 630
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…#2286) * Implement configurable poll interval for transactions Add poll interval configuration for transaction polling * liint
🗒️ Description
uv run fill --until Amsterdam -v -s --clean -k "fork_Amsterdam and zero_byte_True and exceed_tx_gas_limit_False and correct_intrinsic_cost_in_transaction_gas_limit_True"🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture