Skip to content

chore(tests): EIP-7825 test fix to avoid 3 failures on EIP-7976 ci run - #2286

Merged
spencer-tb merged 1 commit into
ethereum:forks/amsterdamfrom
felix314159:fix-7825-for-7976
Feb 23, 2026
Merged

spencer-tb merged 1 commit into
ethereum:forks/amsterdamfrom
felix314159:fix-7825-for-7976

Conversation

@felix314159

Copy link
Copy Markdown
Contributor

🗒️ Description

uv run fill --until Amsterdam -v -s --clean -k "fork_Amsterdam and zero_byte_True and exceed_tx_gas_limit_False and correct_intrinsic_cost_in_transaction_gas_limit_True"

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@spencer-tb spencer-tb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_tx_gas_limit_cap_contract_creation uses the same gas_available // total_cost_floor_per_token pattern, not failing now but might break if gas repricing hits that path. Worth converting to max_count_with_intrinsic_cost_at_most in a follow-up.

@spencer-tb

spencer-tb commented Feb 23, 2026 •

Copy link
Copy Markdown
Contributor

Created an issue with other tests that have similar ways of calcuting (nothing failing). It would be nice to update them in the future though. #2289

@spencer-tb spencer-tb added C-chore Category: chore A-tests Area: Consensus tests. labels Feb 23, 2026
@spencer-tb spencer-tb changed the title fix(test): EIP-7825 test fix to avoid 3 failures on 7976 ci run chore(tests): EIP-7825 test fix to avoid 3 failures on EIP-7976 ci run Feb 23, 2026
@spencer-tb
spencer-tb merged commit b5e62de into ethereum:forks/amsterdam Feb 23, 2026
12 checks passed
@codecov

codecov Bot commented Feb 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.86%. Comparing base (fe54c2e) to head (7355c09).
⚠️ Report is 3 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2286   +/-   ##
================================================
  Coverage            85.86%   85.86%           
================================================
  Files                  599      599           
  Lines                39390    39390           
  Branches              3770     3770           
================================================
  Hits                 33822    33822           
  Misses                4938     4938           
  Partials               630      630           
Flag Coverage Δ
unittests 85.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

flcl42 pushed a commit to flcl42/execution-specs that referenced this pull request Apr 10, 2026
…#2286)

* Implement configurable poll interval for transactions

Add poll interval configuration for transaction polling

* liint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants