Skip to content

fill: plain pytest test in a fixture directory crashes collection with INTERNALERROR #3608

Closed

Description

@CPerezz

A test function under tests/ that does not request state_test/blockchain_test/transaction_test makes fill abort during collection instead of being skipped or reported.

Reproduce: add a file tests/frontier/mpt/test_probe.py containing def test_x(): assert True, then run uv run fill tests/frontier/mpt/ --fork Osaka.

Result: INTERNALERROR> ValueError: No spec type format found in the test item. raised from packages/testing/src/execution_testing/cli/pytest_commands/plugins/filler/filler.py in pytest_collection_modifyitems at the get_spec_format_for_item(params) call. No tests run.

Expected: either the item is deselected with a clear message, or collection fails with an actionable error naming the offending test.

Context: found while adding a helper self-check next to tests/frontier/mpt/ (PR #3600). Workaround used there: run the check at import time from a non-test_ module.

Activity

  1. CodeTrainerMan commented on Sep 21, 2026

    @CodeTrainerMan

    Hi @CPerezz, I'd like to take this one.

    Plan: in pytest_collection_modifyitems (filler.py), detect test items collected under tests/ that request no spec type (state_test/blockchain_test/transaction_test) and deselect them with an actionable message naming the offending test, instead of letting get_spec_format_for_item() raise ValueError that pytest reports as INTERNALERROR.

    Opening a PR shortly.

  2. added a commit that references this issue on Sep 29, 2026
    05fec9a
  3. added a commit that references this issue on Oct 5, 2026
    b5e42b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions