-
Notifications
You must be signed in to change notification settings - Fork 510
Replace hardcoded fork paths with Hardfork class #1426
Copy link
Copy link
Labels
A-spec-toolsArea: Specification Tooling—Tools for the Ethereum specification (eg. `src/ethereum_spec_tools/*`)Area: Specification Tooling—Tools for the Ethereum specification (eg. `src/ethereum_spec_tools/*`)C-featCategory: an improvement or new featureCategory: an improvement or new featureE-easyExperience: easy, good for newcomersExperience: easy, good for newcomersstaleThe Issue/PR has not had any activity for 60 days. PRs will be automatically closed.The Issue/PR has not had any activity for 60 days. PRs will be automatically closed.
Description
Activity
Metadata
Metadata
Assignees
Labels
A-spec-toolsArea: Specification Tooling—Tools for the Ethereum specification (eg. `src/ethereum_spec_tools/*`)Area: Specification Tooling—Tools for the Ethereum specification (eg. `src/ethereum_spec_tools/*`)C-featCategory: an improvement or new featureCategory: an improvement or new featureE-easyExperience: easy, good for newcomersExperience: easy, good for newcomersstaleThe Issue/PR has not had any activity for 60 days. PRs will be automatically closed.The Issue/PR has not had any activity for 60 days. PRs will be automatically closed.
There are a few locations that manually import or otherwise reference hard forks:
Non-exhaustive location list.
execution-specs/src/ethereum_optimized/__init__.py
Line 38 in cdbe21f
execution-specs/src/ethereum_optimized/__init__.py
Line 57 in cdbe21f
execution-specs/src/ethereum_optimized/fork.py
Line 44 in cdbe21f
execution-specs/src/ethereum_optimized/state_db.py
Lines 60 to 61 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/loaders/fork_loader.py
Line 30 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/loaders/fork_loader.py
Line 36 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/loaders/fork_loader.py
Line 46 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/__init__.py
Line 177 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/__init__.py
Line 185 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/__init__.py
Line 262 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/__init__.py
Line 282 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/__init__.py
Line 290 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/__init__.py
Line 295 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 79 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 98 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 133 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 172 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 214 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 235 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 250 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 269 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/env.py
Line 289 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/t8n_types.py
Line 140 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/t8n_types.py
Line 183 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/t8n_types.py
Line 208 in cdbe21f
execution-specs/src/ethereum_spec_tools/evm_tools/t8n/t8n_types.py
Line 215 in cdbe21f
These should be converted to use
Hardforkinstead. Finding fork packages is non-trivial, so we should centralize that logic in one place.