feat(fw): add optional verify_sync flag to hive blockchain tests - #431
Conversation
|
I like this a lot! 💯 Are you thinking that syncing should be specific to certain tests, after processing and setting the head post complex scenario, or applied to the end of all tests? Or even simple specific sync tests for each fork? I tried running this modification for some the One question arises for me: instead of creating a sync payload could we not use the last engine new payload in the test? If we use a sync payload, when we integrate consume fully within EEST it should be straight forward enough to generate this payload on the fly. |
The problem is that if the last engine payload is the one that triggers some special scenario you'd like to test under sync, and you provide this payload via the engine API, then we are not really testing syncing because the payload arrives in full via the engine api. Even in cases where we have more than one payload, we won't be testing syncing for the last one. |
verify_sync flag to hive blockchain testsverify_sync flag to hive blockchain tests
4834a2b to
31ee9ad
Compare
spencer-tb
left a comment
There was a problem hiding this comment.
LGTM - added the changelog.
🗒️ Description
Adds an optional
verify_syncflag for hive (or blockchain Engine API tests) to pick up and test a second client syncing to the first client.Syncing is tricky to some clients and we actually need to send a full header via
engine_newPayloadVNfor some of them to start the sync process.So this change also appends an empty block on top of the latest head of the test to use as syncing head.
🔗 Related Issues
None.
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.