Skip to content

Hive: Non-required field failing the hive tests #631

Description

@brbrr

Transaction RPC responses have v and gasPrice fields marked as deprecated, thus they are not required. But the generated test fixtures for Hive tests do have them. So any client that does not return these fields will fail the tests.

Such behavior creates confusion regarding what should be considered "spec compliant". While it makes sense to keep these fields for backward compatibility for legacy RPC consumers, it also makes it hard to understand how to approach such discrepancies.

I see a few solutions to address this issue:

  • filter out non-required fields on test fixture generation and/or hive tests
  • mark these fields as required

Which IMO not ideal. Were there any discussions in this regard?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions