`eth_estimateGas` With Block Hash Parameter

[nlordell]

I noticed that the eth_estimateGas method’s Block field is specified to only accept a block number or tag (i.e. “latest”, etc.). However, other related methods (specifically eth_call) are also specified to take a block hash. eth_estimateGas seems like the odd-method-out in this regard and I was wondering if this was intentional or an oversight from when more methods transitioned to accepting block hashes as parameters.

FWIW, experimentally nodes seem to accept block hashes for eth_estimateGas.

[O1ahmad]

On main, eth_call uses BlockNumberOrTagOrHash but eth_estimateGas and eth_createAccessList still use BlockNumberOrTag. Was that intentional? Clients seem to accept bare block hashes for estimateGas in practice.

If the intent is parity with eth_call, I can open a small PR switching those Block params to BlockNumberOrTagOrHash.

[MysticRyuujin]

It's probably just an oversight, if all the nodes support it let's just update it to BlockNumberOrTagOrHash as @O1ahmad suggests.