Deprecate pre electra attestation submissions#531
Closed
eserilev wants to merge 1 commit into
Closed
Conversation
Member
|
not really in favor of this on the spec side, so far all apis have been kept backward compatible, implementations can choose to stop supporting previous forks if they would like to |
Contributor
Author
|
sounds good, I'll close this then |
mergify Bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Jun 17, 2025
#6970 This allows for us to receive `SingleAttestation` over gossip and process it without converting. There is still a conversion to `Attestation` as a final step in the attestation verification process, but by then the `SingleAttestation` is fully verified. I've also fully removed the `submitPoolAttestationsV1` endpoint as its been deprecated I've also pre-emptively deprecated supporting `Attestation` in `submitPoolAttestationsV2` endpoint. See here for more info: ethereum/beacon-APIs#531 I tried to the minimize the diff here by only making the "required" changes. There are some unnecessary complexities with the way we manage the different attestation verification wrapper types. We could probably consolidate this to one wrapper type and refactor this even further. We could leave that to a separate PR if we feel like cleaning things up in the future. Note that I've also updated the test harness to always submit `SingleAttestation` regardless of fork variant. I don't see a problem in that approach and it allows us to delete more code :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to deprecate support for pre-electra
Attestationsin thesubmitPoolAttestationsV2endpoint. Since we are post Electra it seems that there is no reason to support the pre-Electra variant. It also allows client teams to simplify the implementation of this endpoint (e.g. Lighthouse can remove 100-ish lines of code with this deprecation). To be spec compliant clients must already be submittingSingleAttestations to this endpoint, so unless there are non-spec compliant client implementations, this shouldn't cause any disruptions.